[PR #1530] [MERGED] Fix notch detection to work on all machines #1875

New issue

Closed

opened 2026-03-03 19:09:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1530
Author: @mitchellmebane
Created: 6/27/2024
Status: ✅ Merged
Merged: 6/27/2024
Merged by: @Depal1

Base: develop ← Head: notch-detection

📝 Commits (1)

73e4e2e Make notch detection work without hard-coded model list

📊 Changes

1 file changed (+3 additions, -7 deletions)

View changed files

📝 PlayCover/Model/AppSettings.swift (+3 -7)

📄 Description

This replaces the hard-coded list of Mac models that have a notch with a runtime check.

I'm checking if any connected screen has a notch because that should provide equivalent behavior to the model check.

I left the NSScreen.getMacModel() extension method in, but it's not used any more, so I can remove it if desired.

Resolves #1516.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1530 **Author:** [@mitchellmebane](https://github.com/mitchellmebane) **Created:** 6/27/2024 **Status:** ✅ Merged **Merged:** 6/27/2024 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `notch-detection` --- ### 📝 Commits (1) - [`73e4e2e`](https://github.com/PlayCover/PlayCover/commit/73e4e2e0b8cfeed282f6d6e88a340264e94c5e03) Make notch detection work without hard-coded model list ### 📊 Changes **1 file changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/AppSettings.swift` (+3 -7) </details> ### 📄 Description This replaces the hard-coded list of Mac models that have a notch with a runtime check. I'm checking if _any_ connected screen has a notch because that should provide equivalent behavior to the model check. I left the `NSScreen.getMacModel()` extension method in, but it's not used any more, so I can remove it if desired. Resolves #1516. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>