[PR #1397] [MERGED] fix ci pipelines again #1860

New issue

Closed

opened 2026-03-03 19:09:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1397
Author: @lixin9311
Created: 2/21/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @TheMoonThatRises

Base: develop ← Head: fix/ci-pipeline

📝 Commits (1)

ad29f47 fix ci pipelines again

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 .github/workflows/1.build_release.yml (+1 -1)
📝 PlayCover.xcodeproj/project.pbxproj (+1 -1)

📄 Description

Summary

Updated the codesign script (fixed in https://github.com/PlayCover/PlayCover/pull/1385, but in a wrong way)
include swiftlint. macos-14 runner does not have it pre-installed

Pipeline Status: https://github.com/PlayCover/PlayCover/actions/runs/7987502714/job/21810109159

New codesign script:

# Type a script or drag a script file from your workspace to insert its path.
set -euo pipefail

IDENTITY=${EXPANDED_CODE_SIGN_IDENTITY_NAME};
# Apple Development: XIN LI (33X85HBRP6)
echo Signing identity $IDENTITY;

codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework/PlugIns/AKInterface.bundle;
codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework;

# sign sparkle
LOCATION="${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Sparkle.framework";
echo Sparkle Signing location $LOCATION;
codesign -f -o runtime -s "$IDENTITY" "$LOCATION/Versions/B/Autoupdate";
codesign -f -o runtime -s "$IDENTITY" "$LOCATION/Versions/B/Updater.app";
codesign -f -o runtime -s "$IDENTITY" "$LOCATION/Versions/B/XPCServices/Downloader.xpc";
codesign -f -o runtime -s "$IDENTITY" "$LOCATION/Versions/B/XPCServices/Installer.xpc";
codesign -f -o runtime -s "$IDENTITY" "$LOCATION";

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1397 **Author:** [@lixin9311](https://github.com/lixin9311) **Created:** 2/21/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Base:** `develop` ← **Head:** `fix/ci-pipeline` --- ### 📝 Commits (1) - [`ad29f47`](https://github.com/PlayCover/PlayCover/commit/ad29f47f097e238f44644e412ea0ee541f989ce0) fix ci pipelines again ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/1.build_release.yml` (+1 -1) 📝 `PlayCover.xcodeproj/project.pbxproj` (+1 -1) </details> ### 📄 Description ## Summary 1. Updated the codesign script (fixed in https://github.com/PlayCover/PlayCover/pull/1385, but in a wrong way) 2. include `swiftlint`. [macos-14](https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md) runner does not have it pre-installed Pipeline Status: https://github.com/PlayCover/PlayCover/actions/runs/7987502714/job/21810109159 New codesign script: ```shell # Type a script or drag a script file from your workspace to insert its path. set -euo pipefail IDENTITY=${EXPANDED_CODE_SIGN_IDENTITY_NAME}; # Apple Development: XIN LI (33X85HBRP6) echo Signing identity $IDENTITY; codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework/PlugIns/AKInterface.bundle; codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework; # sign sparkle LOCATION="${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Sparkle.framework"; echo Sparkle Signing location $LOCATION; codesign -f -o runtime -s "$IDENTITY" "$LOCATION/Versions/B/Autoupdate"; codesign -f -o runtime -s "$IDENTITY" "$LOCATION/Versions/B/Updater.app"; codesign -f -o runtime -s "$IDENTITY" "$LOCATION/Versions/B/XPCServices/Downloader.xpc"; codesign -f -o runtime -s "$IDENTITY" "$LOCATION/Versions/B/XPCServices/Installer.xpc"; codesign -f -o runtime -s "$IDENTITY" "$LOCATION"; ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>