[PR #1384] [MERGED] fix: make observation of modifier keys centralized #1858

New issue

Closed

opened 2026-03-03 19:09:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1384
Author: @ohaiibuzzle
Created: 2/14/2024
Status: ✅ Merged
Merged: 2/14/2024
Merged by: @TheMoonThatRises

Base: develop ← Head: fix/centralized-modifier-monitoring

📝 Commits (2)

856b24e fix: make observation of modifier keys centralized
795e7d2 fix: remove debug statement

📊 Changes

4 files changed (+53 additions, -11 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+4 -0)
📝 PlayCover/AppInstaller/Installer.swift (+2 -5)
➕ PlayCover/Utils/ModifierKeyObserver.swift (+41 -0)
📝 PlayCover/Views/Settings/KeyCoverSettings.swift (+6 -6)

📄 Description

(first of many) Things that I would clean up in PC

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1384 **Author:** [@ohaiibuzzle](https://github.com/ohaiibuzzle) **Created:** 2/14/2024 **Status:** ✅ Merged **Merged:** 2/14/2024 **Merged by:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Base:** `develop` ← **Head:** `fix/centralized-modifier-monitoring` --- ### 📝 Commits (2) - [`856b24e`](https://github.com/PlayCover/PlayCover/commit/856b24eaa9cd4468a508a2aa881edc73dda42826) fix: make observation of modifier keys centralized - [`795e7d2`](https://github.com/PlayCover/PlayCover/commit/795e7d23faf76cd9a7d9738bdedb59532b3506fa) fix: remove debug statement ### 📊 Changes **4 files changed** (+53 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+4 -0) 📝 `PlayCover/AppInstaller/Installer.swift` (+2 -5) ➕ `PlayCover/Utils/ModifierKeyObserver.swift` (+41 -0) 📝 `PlayCover/Views/Settings/KeyCoverSettings.swift` (+6 -6) </details> ### 📄 Description (first of many) Things that I would clean up in PC --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>