[PR #1385] [MERGED] fix codesign script for xcode 15 #1856

New issue

Closed

opened 2026-03-03 19:09:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1385
Author: @lixin9311
Created: 2/14/2024
Status: ✅ Merged
Merged: 2/14/2024
Merged by: @TheMoonThatRises

Base: develop ← Head: fix/xcode-15

📝 Commits (1)

d7f13d7 fix codesign script for xcode 15

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+1 -1)

📄 Description

Fix build phase script for xcode 15+

I don't know from which version the script breaks.
Let's assume 15 for now.

New script:

# Type a script or drag a script file from your workspace to insert its path.
set -euo pipefail

IDENTITY=${EXPANDED_CODE_SIGN_IDENTITY_NAME};
# Apple Development: XIN LI (33X85HBRP6)
echo Signing identity $IDENTITY;

codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework/PlugIns/AKInterface.bundle;
codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework;

# sign sparkle
if [ "$XCODE_VERSION_MAJOR" -ge "1500" ]; then
	LOCATION="${BUILD_DIR%Build/*}SourcePackages/artifacts/sparkle/Sparkle/Sparkle.xcframework/macos-arm64_x86_64/Sparkle.framework";
	echo Sparkle Signing location $LOCATION;
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Autoupdate";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Updater.app";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Downloader.xpc";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Installer.xpc";
else
	LOCATION="${BUILD_DIR%Build/*}SourcePackages/artifacts/sparkle/Sparkle.xcframework/macos-arm64_x86_64/Sparkle.framework";
	echo Sparkle Signing location $LOCATION;
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Autoupdate";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Updater.app";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Downloader.xpc";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Installer.xpc";
fi

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1385 **Author:** [@lixin9311](https://github.com/lixin9311) **Created:** 2/14/2024 **Status:** ✅ Merged **Merged:** 2/14/2024 **Merged by:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Base:** `develop` ← **Head:** `fix/xcode-15` --- ### 📝 Commits (1) - [`d7f13d7`](https://github.com/PlayCover/PlayCover/commit/d7f13d7a5fe2b714dc902aa19d49c8651ac79b31) fix codesign script for xcode 15 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+1 -1) </details> ### 📄 Description Fix build phase script for xcode 15+ I don't know from which version the script breaks. Let's assume 15 for now. New script: ```shell # Type a script or drag a script file from your workspace to insert its path. set -euo pipefail IDENTITY=${EXPANDED_CODE_SIGN_IDENTITY_NAME}; # Apple Development: XIN LI (33X85HBRP6) echo Signing identity $IDENTITY; codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework/PlugIns/AKInterface.bundle; codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework; # sign sparkle if [ "$XCODE_VERSION_MAJOR" -ge "1500" ]; then LOCATION="${BUILD_DIR%Build/*}SourcePackages/artifacts/sparkle/Sparkle/Sparkle.xcframework/macos-arm64_x86_64/Sparkle.framework"; echo Sparkle Signing location $LOCATION; codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Autoupdate"; codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Updater.app"; codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Downloader.xpc"; codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Installer.xpc"; else LOCATION="${BUILD_DIR%Build/*}SourcePackages/artifacts/sparkle/Sparkle.xcframework/macos-arm64_x86_64/Sparkle.framework"; echo Sparkle Signing location $LOCATION; codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Autoupdate"; codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Updater.app"; codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Downloader.xpc"; codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Installer.xpc"; fi ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>