mirror of
https://github.com/PlayCover/PlayCover.git
synced 2026-04-26 08:15:56 +03:00
[PR #1274] [MERGED] Adopt asynchronous methods to avoid UI blocking #1844
Labels
No labels
UI
app-support
bug
bug
documentation
duplicate
enhancement
game-support
good first issue
help wanted / caution
inactive
invalid
macos-beta
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PlayCover#1844
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/PlayCover/PlayCover/pull/1274
Author: @Stv-X
Created: 12/15/2023
Status: ✅ Merged
Merged: 5/29/2024
Merged by: @TheMoonThatRises
Base:
develop← Head:develop📝 Commits (10+)
f39a1c5Modify PlayTools injection/removal methods to execute asynchronously to prevent UI blockingd4813cbFix SwiftLint violations in AppSettingsView.swift8ce61cdAdjust the height of ProgressView to match the interface.1ed5169Added async support for the two functionalities of "Insert Introspection libraries" and "Force Insert iOS Frameworks".d6e8a2cAdd async support for "Clear App Data" button.5539347Merge branch 'PlayCover:develop' into develop9cd6cd4Add async support for app uninstaller.f8b9940Polish the UI and simplify the code.ac36d7eFix the typo issue of UninstallVM.swiftb15d307Use a single variable of enumeration type 'BlockingTask' to simplify the code.📊 Changes
6 files changed (+139 additions, -52 deletions)
View changed files
📝
PlayCover/AppInstaller/Installer.swift(+1 -1)📝
PlayCover/Model/PlayApp.swift(+4 -4)📝
PlayCover/Utils/PlayTools.swift(+2 -3)📝
PlayCover/Views/App Views/PlayAppView.swift(+4 -16)📝
PlayCover/Views/AppSettingsView.swift(+91 -11)📝
PlayCover/Views/Uninstaller.swift(+37 -17)📄 Description
These changes avoid the stuck with macOS spinning beach ball caused by UI blocking while performing long-consuming work.
before:

after:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.