[PR #1087] [MERGED] Set Application Category Type #1812

New issue

Closed

opened 2026-03-03 19:09:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1087
Author: @TheMoonThatRises
Created: 9/8/2023
Status: ✅ Merged
Merged: 9/25/2023
Merged by: @JoseMoreville

Base: develop ← Head: feat/customapptype

📝 Commits (1)

6a350aa feat: allow user to set app category type

📊 Changes

5 files changed (+112 additions, -8 deletions)

View changed files

📝 PlayCover/AppInstaller/Installer.swift (+3 -0)
📝 PlayCover/Model/AppInfo.swift (+49 -0)
📝 PlayCover/Views/AppSettingsView.swift (+34 -1)
📝 PlayCover/Views/Settings/InstallSettings.swift (+25 -7)
📝 PlayCover/en.lproj/Localizable.strings (+1 -0)

📄 Description

This allows the user to set the category of the app by adding the key LSApplicationCategoryType to the Info.plist located in the application. This can be changed under Misc in the application's settings.

More specifically, this feature enables and closes #1085 "Game Mode", which can be accomplished by the user setting the application type to public.app-category.games for those on MacOS Sonoma.

This change is tested on MacOS Sonoma Developer Beta 23A5337a. This should not affect the changes, but should still be tested on a stable version of MacOS.

Other Notes for reviewers:

Should LSApplicationCategoryType be localised? Currently, the code is implemented but was too time consuming to implement it in the localisation files.
Should the installer popup be updated to a sheet or something similar to accommodate for the user to specify the application category type on installation? The setting has been implemented to set all the installing types to the specified value but per installation type setting would be require some major refactoring.
Should the application inherent the application type from the IPA? Since the application's Info.plist does not initially have the key LSApplicationCategoryType, it would have to be located elsewhere as iOS apps still have the application category types. I will look into that but since it is not already implemented, I am not too sure it will work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1087 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 9/8/2023 **Status:** ✅ Merged **Merged:** 9/25/2023 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `feat/customapptype` --- ### 📝 Commits (1) - [`6a350aa`](https://github.com/PlayCover/PlayCover/commit/6a350aa290b2be7a3c9f9a551de611adaba2f45d) feat: allow user to set app category type ### 📊 Changes **5 files changed** (+112 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/AppInstaller/Installer.swift` (+3 -0) 📝 `PlayCover/Model/AppInfo.swift` (+49 -0) 📝 `PlayCover/Views/AppSettingsView.swift` (+34 -1) 📝 `PlayCover/Views/Settings/InstallSettings.swift` (+25 -7) 📝 `PlayCover/en.lproj/Localizable.strings` (+1 -0) </details> ### 📄 Description This allows the user to set the category of the app by adding the key `LSApplicationCategoryType` to the `Info.plist` located in the application. This can be changed under Misc in the application's settings. More specifically, this feature enables and closes #1085 "Game Mode", which can be accomplished by the user setting the application type to `public.app-category.games` for those on MacOS Sonoma. **This change is tested on MacOS Sonoma Developer Beta 23A5337a**. This should not affect the changes, but should still be tested on a stable version of MacOS. Other Notes for reviewers: - Should `LSApplicationCategoryType` be localised? Currently, the code is implemented but was too time consuming to implement it in the localisation files. - Should the installer popup be updated to a `sheet` or something similar to accommodate for the user to specify the application category type on installation? The setting has been implemented to set all the installing types to the specified value but per installation type setting would be require some major refactoring. - Should the application inherent the application type from the IPA? Since the application's `Info.plist` does not initially have the key `LSApplicationCategoryType`, it would have to be located elsewhere as iOS apps still have the application category types. I will look into that but since it is not already implemented, I am not too sure it will work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>