[PR #1060] [MERGED] Sidebar toggle position oversight #1809

New issue

Closed

opened 2026-03-03 19:09:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1060
Author: @404oops
Created: 7/28/2023
Status: ✅ Merged
Merged: 9/25/2023
Merged by: @JoseMoreville

Base: develop ← Head: patch-1

📝 Commits (1)

ef90a42 Update MainView.swift

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 PlayCover/Views/MainView.swift (+1 -1)

📄 Description

I saw a major design oversight regarding the sidebar button.

https://github.com/PlayCover/PlayCover/assets/51266541/f6db7c05-7218-41ba-9113-de200a06894b

The Sidebar button is positioned to .navigation which doesn't really make sense since the user needs to chase it if they misclick.

I removed the position so that it sticks to default (left side)

https://github.com/PlayCover/PlayCover/assets/51266541/348e45e3-8004-4393-9ef7-195c69303cc7

The code for this entry can be found here as "proof" that it works

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1060 **Author:** [@404oops](https://github.com/404oops) **Created:** 7/28/2023 **Status:** ✅ Merged **Merged:** 9/25/2023 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`ef90a42`](https://github.com/PlayCover/PlayCover/commit/ef90a425f3dfb342ba1929dbab45c0e0c9525150) Update MainView.swift ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Views/MainView.swift` (+1 -1) </details> ### 📄 Description I saw a major design oversight regarding the sidebar button. https://github.com/PlayCover/PlayCover/assets/51266541/f6db7c05-7218-41ba-9113-de200a06894b The Sidebar button is positioned to `.navigation` which doesn't really make sense since the user needs to chase it if they misclick. I removed the position so that it sticks to default (left side) https://github.com/PlayCover/PlayCover/assets/51266541/348e45e3-8004-4393-9ef7-195c69303cc7 The code for this entry can be found [here](https://github.com/404oops/NamecheapDDNS/blob/507021107872c1ffacf3ae7a8c04e75e8e7b5c6e/NamecheapDDNS/ContentView.swift#L38-L45) as "proof" that it works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>