[PR #860] [MERGED] Fix XCLT-less Installer #1780

Closed
opened 2026-03-03 19:08:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/860
Author: @IsaacMarovitz
Created: 3/11/2023
Status: Merged
Merged: 3/16/2023
Merged by: @JoseMoreville

Base: developHead: fix-conflicts


📝 Commits (6)

  • 410d09f Fix XCLT-less Installer (#830)
  • 4f4af06 Fix space check
  • 17c51c8 Xyct suggestion not sure if this is necessary
  • 77b37ad Who needs error checking anyways
  • 5f709db Fix PT failing to install first time in FAT binaries
  • 9729062 xclt less installer macho converter code cleanup (#851)

📊 Changes

6 files changed (+332 additions, -365 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+4 -0)
📝 PlayCover/AppInstaller/Installer.swift (+9 -9)
📝 PlayCover/Model/PlayApp.swift (+1 -1)
📝 PlayCover/Utils/Extensions/DataExtensions.swift (+5 -2)
PlayCover/Utils/Macho.swift (+288 -0)
📝 PlayCover/Utils/PlayTools.swift (+25 -353)

📄 Description

This fixes the conflicts in the PR:

Fix XCLT-less installer for realsies.

Tested apps (all working):

  • Genshin Impact
  • Payback2
  • Eversoul
  • Geometry Dash
  • Duolingo
  • Netflix
  • Where's My Water 2
  • Most Wanted
  • Aidoku
  • Angry Birds
  • Crunchyroll
  • Dadish 1, 2, 3
  • Deltroid
  • Disney+
  • LIFX
  • NIKKE
  • PvZ 1, 2
  • Turnip Boy
  • Twitch

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/860 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 3/11/2023 **Status:** ✅ Merged **Merged:** 3/16/2023 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `fix-conflicts` --- ### 📝 Commits (6) - [`410d09f`](https://github.com/PlayCover/PlayCover/commit/410d09ff6f0cec84a96240b1ec867c802e7d1975) Fix XCLT-less Installer (#830) - [`4f4af06`](https://github.com/PlayCover/PlayCover/commit/4f4af0644c7f3c8509d3be16fce983106bd721a8) Fix space check - [`17c51c8`](https://github.com/PlayCover/PlayCover/commit/17c51c8b08a1a2d1616b3c6f6bb091b558032d10) Xyct suggestion not sure if this is necessary - [`77b37ad`](https://github.com/PlayCover/PlayCover/commit/77b37ad7cf39b516fe77f2e6fd9fa56cd5319dea) Who needs error checking anyways - [`5f709db`](https://github.com/PlayCover/PlayCover/commit/5f709dbc8beb081e8f62a0dd052290be0aa4060a) Fix PT failing to install first time in FAT binaries - [`9729062`](https://github.com/PlayCover/PlayCover/commit/9729062ca21e85b1fcdedb42681bd632600b9f9b) xclt less installer macho converter code cleanup (#851) ### 📊 Changes **6 files changed** (+332 additions, -365 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+4 -0) 📝 `PlayCover/AppInstaller/Installer.swift` (+9 -9) 📝 `PlayCover/Model/PlayApp.swift` (+1 -1) 📝 `PlayCover/Utils/Extensions/DataExtensions.swift` (+5 -2) ➕ `PlayCover/Utils/Macho.swift` (+288 -0) 📝 `PlayCover/Utils/PlayTools.swift` (+25 -353) </details> ### 📄 Description This fixes the conflicts in the PR: Fix XCLT-less installer for realsies. Tested apps (all working): - Genshin Impact - Payback2 - Eversoul - Geometry Dash - Duolingo - Netflix - Where's My Water 2 - Most Wanted - Aidoku - Angry Birds - Crunchyroll - Dadish 1, 2, 3 - Deltroid - Disney+ - LIFX - NIKKE - PvZ 1, 2 - Turnip Boy - Twitch --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:08:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1780
No description provided.