[PR #851] [MERGED] xclt less installer macho converter code cleanup #1776

New issue

Closed

opened 2026-03-03 19:08:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/851
Author: @XuYicong
Created: 3/9/2023
Status: ✅ Merged
Merged: 3/9/2023
Merged by: @Depal1

Base: test-xcode-less-installer ← Head: xclt-less

📝 Commits (6)

ed32aa2 macho converter code cleanup
05f0842 lint lc iterate in playtools
8b12f56 add back enough space check
ea14cc3 Update Macho.swift
a056d57 Add Macho.swift to project
6108f27 Indentation adjustments

📊 Changes

6 files changed (+314 additions, -334 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+4 -0)
📝 PlayCover/AppInstaller/Installer.swift (+2 -2)
📝 PlayCover/Model/PlayApp.swift (+1 -1)
📝 PlayCover/Utils/Extensions/DataExtensions.swift (+5 -2)
➕ PlayCover/Utils/Macho.swift (+288 -0)
📝 PlayCover/Utils/PlayTools.swift (+14 -329)

📄 Description

Created a new file Macho.swift to put macho-related code, so that PlayTools has less lines than swiftlint's upper bound

Added sanity checks while iterating load commands.

Added byte order checks while replacing load commands.

Variable names changed to more meaningful ones.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/851 **Author:** [@XuYicong](https://github.com/XuYicong) **Created:** 3/9/2023 **Status:** ✅ Merged **Merged:** 3/9/2023 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `test-xcode-less-installer` ← **Head:** `xclt-less` --- ### 📝 Commits (6) - [`ed32aa2`](https://github.com/PlayCover/PlayCover/commit/ed32aa23b72aa83ea0519caf97af7f436d12ea7e) macho converter code cleanup - [`05f0842`](https://github.com/PlayCover/PlayCover/commit/05f084236571641f4c620936d67f9dbe145fd185) lint lc iterate in playtools - [`8b12f56`](https://github.com/PlayCover/PlayCover/commit/8b12f56fb66f2f62b08cb9791ca74931a1e26a86) add back enough space check - [`ea14cc3`](https://github.com/PlayCover/PlayCover/commit/ea14cc36dd4366171e184af70febc358c58ea708) Update Macho.swift - [`a056d57`](https://github.com/PlayCover/PlayCover/commit/a056d571df385d1c159efdbc5fb7f80d07440b90) Add Macho.swift to project - [`6108f27`](https://github.com/PlayCover/PlayCover/commit/6108f27ff6e7e9b78dd8147e7bc71fda87378768) Indentation adjustments ### 📊 Changes **6 files changed** (+314 additions, -334 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+4 -0) 📝 `PlayCover/AppInstaller/Installer.swift` (+2 -2) 📝 `PlayCover/Model/PlayApp.swift` (+1 -1) 📝 `PlayCover/Utils/Extensions/DataExtensions.swift` (+5 -2) ➕ `PlayCover/Utils/Macho.swift` (+288 -0) 📝 `PlayCover/Utils/PlayTools.swift` (+14 -329) </details> ### 📄 Description Created a new file `Macho.swift` to put macho-related code, so that `PlayTools` has less lines than `swiftlint`'s upper bound Added sanity checks while iterating load commands. Added byte order checks while replacing load commands. Variable names changed to more meaningful ones. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>