[PR #832] [CLOSED] Fix XCLT-less Installer (#830) #1768

New issue

Closed

opened 2026-03-03 19:08:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/832
Author: @IsaacMarovitz
Created: 3/2/2023
Status: ❌ Closed

Base: develop ← Head: xcode-less-installer

📝 Commits (4)

1955f32 Fix XCLT-less Installer (#830)
54aafa7 Fix space check
af4163e Xyct suggestion not sure if this is necessary
6053373 Who needs error checking anyways

📊 Changes

1 file changed (+173 additions, -185 deletions)

View changed files

📝 PlayCover/Utils/PlayTools.swift (+173 -185)

📄 Description

This should fix XCLT-less installer for realsies this time.

What this PR does:

Reimplements install_name_tool replacement this time it can handle weak and strong LCs
Introduces several major optimisations to clean up code and significantly reduces the number of writes to disk

Thinks to do:

Cleanup PlayTools.swift code
Deal with the "Not enough space in binary" issue
Maybe work to replace the LC at its original index rather than appending
Fix missing padding at end of header

Apps I've tested:

Genshin Impact (Works)
Payback2 (Works)
Eversoul (Works)
Geometry Dash (Works)
Duolingo (Works)
Netflix (Works)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/832 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 3/2/2023 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `xcode-less-installer` --- ### 📝 Commits (4) - [`1955f32`](https://github.com/PlayCover/PlayCover/commit/1955f32d61bb31fb80bc491295b6c9ee2bb95481) Fix XCLT-less Installer (#830) - [`54aafa7`](https://github.com/PlayCover/PlayCover/commit/54aafa79314612e9b6c2e8d256ce0a8a4b01cbb3) Fix space check - [`af4163e`](https://github.com/PlayCover/PlayCover/commit/af4163e6ebf569dff2249c564fcfd09e9bb0d450) Xyct suggestion not sure if this is necessary - [`6053373`](https://github.com/PlayCover/PlayCover/commit/6053373e5a21bdd30d65821168955344a2106ffb) Who needs error checking anyways ### 📊 Changes **1 file changed** (+173 additions, -185 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Utils/PlayTools.swift` (+173 -185) </details> ### 📄 Description This should fix XCLT-less installer for realsies this time. What this PR does: - Reimplements `install_name_tool` replacement this time it can handle weak and strong LCs - Introduces several major optimisations to clean up code and significantly reduces the number of writes to disk Thinks to do: - [x] Cleanup PlayTools.swift code - [x] Deal with the "Not enough space in binary" issue - [x] Maybe work to replace the LC at its original index rather than appending - [x] Fix missing padding at end of header Apps I've tested: - Genshin Impact (Works) - Payback2 (Works) - Eversoul (Works) - Geometry Dash (Works) - Duolingo (Works) - Netflix (Works) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>