[PR #825] [CLOSED] Revert "Add `install_name_tool` replacement" #1763

New issue

Closed

opened 2026-03-03 19:08:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/825
Author: @IsaacMarovitz
Created: 3/1/2023
Status: ❌ Closed

Base: develop ← Head: revert-794-installer-fix

📝 Commits (1)

5164667 Revert "Add install_name_tool replacement (#794)"

📊 Changes

1 file changed (+0 additions, -30 deletions)

View changed files

📝 PlayCover/Utils/PlayTools.swift (+0 -30)

📄 Description

Reverts PlayCover/PlayCover#794

I made several mistakes in implementing this, and it has proven more problematic than lacking install_name_tool functionality altogether. I will fix this functionality later, but for now I think it's best if this naive implementation is removed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/825 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 3/1/2023 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `revert-794-installer-fix` --- ### 📝 Commits (1) - [`5164667`](https://github.com/PlayCover/PlayCover/commit/5164667f36fd9bb3dd5a852d8f6e5b1f37bcc5ed) Revert "Add `install_name_tool` replacement (#794)" ### 📊 Changes **1 file changed** (+0 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Utils/PlayTools.swift` (+0 -30) </details> ### 📄 Description Reverts PlayCover/PlayCover#794 I made several mistakes in implementing this, and it has proven more problematic than lacking `install_name_tool` functionality altogether. I will fix this functionality later, but for now I think it's best if this naive implementation is removed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>