[PR #802] [MERGED] High resolution warning #1759

Closed
opened 2026-03-03 19:08:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/802
Author: @TheMoonThatRises
Created: 2/14/2023
Status: Merged
Merged: 2/15/2023
Merged by: @JoseMoreville

Base: developHead: feat/highreswarning


📝 Commits (1)

  • b5f4f58 feat: high resolution warning

📊 Changes

2 files changed (+18 additions, -1 deletions)

View changed files

📝 PlayCover/Views/AppSettingsView.swift (+17 -1)
📝 PlayCover/en.lproj/Localizable.strings (+1 -0)

📄 Description

High app resolution will provide a warning in settings when it is selected. The height and width of the selected resolution are multiplied and compared against 2,621,440 pixels (2048x1280), as it was found that that would cause crashing in certain graphic intensive apps.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/802 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 2/14/2023 **Status:** ✅ Merged **Merged:** 2/15/2023 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `feat/highreswarning` --- ### 📝 Commits (1) - [`b5f4f58`](https://github.com/PlayCover/PlayCover/commit/b5f4f58b5425e836967f78d9371ce5407cd7b18c) feat: high resolution warning ### 📊 Changes **2 files changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Views/AppSettingsView.swift` (+17 -1) 📝 `PlayCover/en.lproj/Localizable.strings` (+1 -0) </details> ### 📄 Description High app resolution will provide a warning in settings when it is selected. The height and width of the selected resolution are multiplied and compared against 2,621,440 pixels (2048x1280), as it was found that that would cause crashing in certain graphic intensive apps. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:08:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1759
No description provided.