[PR #753] [MERGED] Add `force_unwrapping` rule to SwiftLint #1742

New issue

Closed

opened 2026-03-03 19:08:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/753
Author: @IsaacMarovitz
Created: 1/29/2023
Status: ✅ Merged
Merged: 3/11/2023
Merged by: @IsaacMarovitz

Base: develop ← Head: force-unwrap

📝 Commits (10+)

a2a0532 Remove force unwraps
54206f1 Remove UIF
aaf3ead Fixes
f659e19 Merge fixes
9638a29 SwiftLint
30a8656 Merge branch 'develop' into force-unwrap
526518b Merge branch 'develop' into force-unwrap
eb3b52a Fixes
d2ea19b Fix errors
f4cc359 Fix typo

📊 Changes

26 files changed (+219 additions, -284 deletions)

View changed files

📝 .swiftlint.yml (+2 -2)
📝 PlayCover.xcodeproj/project.pbxproj (+0 -12)
📝 PlayCover/AppInstaller/Downloader.swift (+26 -24)
📝 PlayCover/AppInstaller/Installer.swift (+1 -6)
➖ PlayCover/IntentFlow/UserIntentFlow.swift (+0 -15)
📝 PlayCover/Model/AppInfo.swift (+12 -19)
📝 PlayCover/Model/PlayApp.swift (+3 -10)
📝 PlayCover/Model/PlayRules.swift (+2 -2)
📝 PlayCover/Utils/AppIntegrity.swift (+9 -7)
📝 PlayCover/Utils/Entitlements.swift (+2 -2)
📝 PlayCover/Utils/Extensions/DataExtensions.swift (+2 -0)
📝 PlayCover/Utils/Extensions/FileExtensions.swift (+3 -2)
📝 PlayCover/Utils/IPA.swift (+11 -7)
📝 PlayCover/Utils/PlayTools.swift (+7 -7)
📝 PlayCover/Utils/Shell.swift (+46 -112)
📝 PlayCover/Utils/SystemConfig.swift (+23 -13)
📝 PlayCover/ViewModel/AppsVM.swift (+2 -2)
📝 PlayCover/ViewModel/StoreVM.swift (+23 -12)
📝 PlayCover/Views/App Views/StoreAppView.swift (+4 -4)
📝 PlayCover/Views/MainView.swift (+1 -0)

...and 6 more files

📄 Description

Removes all force unwraps (except for a few in PlayTools and other places)
Adds the force_unwrapping rule to SwiftLint
Removes disabling of inclusive_language rule from SwiftLint
Removes UIF
Refactors Shell

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/753 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 1/29/2023 **Status:** ✅ Merged **Merged:** 3/11/2023 **Merged by:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Base:** `develop` ← **Head:** `force-unwrap` --- ### 📝 Commits (10+) - [`a2a0532`](https://github.com/PlayCover/PlayCover/commit/a2a0532edac449a89e8c6150a53f53febe3a951b) Remove force unwraps - [`54206f1`](https://github.com/PlayCover/PlayCover/commit/54206f1780667d1d5516699d28c05516eb267c00) Remove UIF - [`aaf3ead`](https://github.com/PlayCover/PlayCover/commit/aaf3ead840a4630bc2f4780bcd3d61b95a5b716e) Fixes - [`f659e19`](https://github.com/PlayCover/PlayCover/commit/f659e195ed242e67d9fb154d0b634a47fffbf048) Merge fixes - [`9638a29`](https://github.com/PlayCover/PlayCover/commit/9638a29658f6049340ac3739b11b4e3a76c5bf23) SwiftLint - [`30a8656`](https://github.com/PlayCover/PlayCover/commit/30a86565b3731c188b186f339595d6041caa5b59) Merge branch 'develop' into force-unwrap - [`526518b`](https://github.com/PlayCover/PlayCover/commit/526518b953bf8e54144765e3f10bd9c26bedcd85) Merge branch 'develop' into force-unwrap - [`eb3b52a`](https://github.com/PlayCover/PlayCover/commit/eb3b52a3a59353696815cc7bfbbe878915a6bdf0) Fixes - [`d2ea19b`](https://github.com/PlayCover/PlayCover/commit/d2ea19b3a677bcb6d6a77effb9fa519785113331) Fix errors - [`f4cc359`](https://github.com/PlayCover/PlayCover/commit/f4cc35951d21a04af0d33e5d5d79b8ead3095a96) Fix typo ### 📊 Changes **26 files changed** (+219 additions, -284 deletions) <details> <summary>View changed files</summary> 📝 `.swiftlint.yml` (+2 -2) 📝 `PlayCover.xcodeproj/project.pbxproj` (+0 -12) 📝 `PlayCover/AppInstaller/Downloader.swift` (+26 -24) 📝 `PlayCover/AppInstaller/Installer.swift` (+1 -6) ➖ `PlayCover/IntentFlow/UserIntentFlow.swift` (+0 -15) 📝 `PlayCover/Model/AppInfo.swift` (+12 -19) 📝 `PlayCover/Model/PlayApp.swift` (+3 -10) 📝 `PlayCover/Model/PlayRules.swift` (+2 -2) 📝 `PlayCover/Utils/AppIntegrity.swift` (+9 -7) 📝 `PlayCover/Utils/Entitlements.swift` (+2 -2) 📝 `PlayCover/Utils/Extensions/DataExtensions.swift` (+2 -0) 📝 `PlayCover/Utils/Extensions/FileExtensions.swift` (+3 -2) 📝 `PlayCover/Utils/IPA.swift` (+11 -7) 📝 `PlayCover/Utils/PlayTools.swift` (+7 -7) 📝 `PlayCover/Utils/Shell.swift` (+46 -112) 📝 `PlayCover/Utils/SystemConfig.swift` (+23 -13) 📝 `PlayCover/ViewModel/AppsVM.swift` (+2 -2) 📝 `PlayCover/ViewModel/StoreVM.swift` (+23 -12) 📝 `PlayCover/Views/App Views/StoreAppView.swift` (+4 -4) 📝 `PlayCover/Views/MainView.swift` (+1 -0) _...and 6 more files_ </details> ### 📄 Description - Removes all force unwraps (except for a few in PlayTools and other places) - Adds the `force_unwrapping` rule to SwiftLint - Removes disabling of `inclusive_language` rule from SwiftLint - Removes UIF - Refactors Shell --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>