[PR #717] [MERGED] Fancy Library Fixes and Improvements #1720

New issue

Closed

opened 2026-03-03 19:08:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/717
Author: @amirsaam
Created: 1/17/2023
Status: ✅ Merged
Merged: 1/21/2023
Merged by: @Depal1

Base: preview-fancy-library ← Head: back-button-fix

📝 Commits (3)

c237746 May Fix It + New Bug 👽
0e8ca47 visual improvement
b88fc76 enlarging screenshots fixes

📊 Changes

5 files changed (+249 additions, -163 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+21 -4)
➖ PlayCover/Utils/ViewExtenstions.swift (+0 -56)
📝 PlayCover/Views/App Views/DetailStoreAppView.swift (+89 -82)
➕ PlayCover/Views/App Views/DetailStoreComponents.swift (+131 -0)
📝 PlayCover/Views/Sidebar Views/IPALibraryView.swift (+8 -21)

📄 Description

Back Button may be fixed in this PR with new Usage of a package named NavigationStack (but has an issue)
Screenshots will be presented on click and user can go through them
App badges now have their own external struct to make the code in DetailStoreAppView cleaner

NavigationStack Issue: If PlayCover goes to background, navigation will be reseted and goes back to root.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/717 **Author:** [@amirsaam](https://github.com/amirsaam) **Created:** 1/17/2023 **Status:** ✅ Merged **Merged:** 1/21/2023 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `preview-fancy-library` ← **Head:** `back-button-fix` --- ### 📝 Commits (3) - [`c237746`](https://github.com/PlayCover/PlayCover/commit/c237746463e9b4823c1134b72c8029b98c3b766c) May Fix It + New Bug :alien: - [`0e8ca47`](https://github.com/PlayCover/PlayCover/commit/0e8ca47b98ca25f1756e10b4167b7fb6868e42f4) visual improvement - [`b88fc76`](https://github.com/PlayCover/PlayCover/commit/b88fc7663b093a415c7189b912652891e10fce39) enlarging screenshots fixes ### 📊 Changes **5 files changed** (+249 additions, -163 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+21 -4) ➖ `PlayCover/Utils/ViewExtenstions.swift` (+0 -56) 📝 `PlayCover/Views/App Views/DetailStoreAppView.swift` (+89 -82) ➕ `PlayCover/Views/App Views/DetailStoreComponents.swift` (+131 -0) 📝 `PlayCover/Views/Sidebar Views/IPALibraryView.swift` (+8 -21) </details> ### 📄 Description - Back Button may be fixed in this PR with new Usage of a package named NavigationStack (but has an issue) - Screenshots will be presented on click and user can go through them - App badges now have their own external struct to make the code in `DetailStoreAppView` cleaner NavigationStack Issue: If PlayCover goes to background, navigation will be reseted and goes back to root. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>