mirror of
https://github.com/PlayCover/PlayCover.git
synced 2026-04-26 00:05:52 +03:00
[PR #711] [MERGED] Remove Xcode CLI Dependancy #1718
Labels
No labels
UI
app-support
bug
bug
documentation
duplicate
enhancement
game-support
good first issue
help wanted / caution
inactive
invalid
macos-beta
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PlayCover#1718
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/PlayCover/PlayCover/pull/711
Author: @IsaacMarovitz
Created: 1/17/2023
Status: ✅ Merged
Merged: 1/21/2023
Merged by: @Depal1
Base:
develop← Head:xcode-cli📝 Commits (10+)
8d11eafRemove otool usage7c7bdb0Start tossing outvtool(Not working :( rn )21e5523Remove use oflipod5b422eRemove replaceLibrariesb2ba31eError checking06944f8SwiftLinta6bc98aEndianness fixes5ae6c52Ignore file_length471376cRemove debug printsd1be5e9Make functions shorter📊 Changes
9 files changed (+357 additions, -64 deletions)
View changed files
📝
PlayCover.xcodeproj/project.pbxproj(+4 -0)📝
PlayCover/AppInstaller/Installer.swift(+0 -1)📝
PlayCover/Model/PlayApp.swift(+1 -1)📝
PlayCover/PlayCoverError.swift(+3 -0)➕
PlayCover/Utils/DataExtensions.swift(+29 -0)📝
PlayCover/Utils/FileExtensions.swift(+0 -1)📝
PlayCover/Utils/PlayTools.swift(+314 -59)📝
PlayCover/Utils/URLExtensions.swift(+5 -2)📝
PlayCover/en.lproj/Localizable.strings(+1 -0)📄 Description
Change:
injectinstall_name_toolusage not converted cause it's not necessary afaikI will leave removing the UI and backend surrounding Xcode CLI to another PR so that the changes from this one can easily be tested in isolation.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.