[PR #711] [MERGED] Remove Xcode CLI Dependancy #1718

Closed
opened 2026-03-03 19:08:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/711
Author: @IsaacMarovitz
Created: 1/17/2023
Status: Merged
Merged: 1/21/2023
Merged by: @Depal1

Base: developHead: xcode-cli


📝 Commits (10+)

📊 Changes

9 files changed (+357 additions, -64 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+4 -0)
📝 PlayCover/AppInstaller/Installer.swift (+0 -1)
📝 PlayCover/Model/PlayApp.swift (+1 -1)
📝 PlayCover/PlayCoverError.swift (+3 -0)
PlayCover/Utils/DataExtensions.swift (+29 -0)
📝 PlayCover/Utils/FileExtensions.swift (+0 -1)
📝 PlayCover/Utils/PlayTools.swift (+314 -59)
📝 PlayCover/Utils/URLExtensions.swift (+5 -2)
📝 PlayCover/en.lproj/Localizable.strings (+1 -0)

📄 Description

Change:

  • Replaces all uses of Xcode CLI with our own implementations, based on inject
  • Installing Xcode CLI would no longer be required after this PR

install_name_tool usage not converted cause it's not necessary afaik

I will leave removing the UI and backend surrounding Xcode CLI to another PR so that the changes from this one can easily be tested in isolation.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/711 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 1/17/2023 **Status:** ✅ Merged **Merged:** 1/21/2023 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `xcode-cli` --- ### 📝 Commits (10+) - [`8d11eaf`](https://github.com/PlayCover/PlayCover/commit/8d11eaf3e1a878fbf5724e650e5f7ed8e2e2436e) Remove otool usage - [`7c7bdb0`](https://github.com/PlayCover/PlayCover/commit/7c7bdb03df75066c8332e61ca3abcb8ee682631e) Start tossing out `vtool` (Not working :( rn ) - [`21e5523`](https://github.com/PlayCover/PlayCover/commit/21e5523e2bfd0af2a721122c03499c6141b3d8ac) Remove use of `lipo` - [`d5b422e`](https://github.com/PlayCover/PlayCover/commit/d5b422e25f5551b9643651090e669e17a6b71689) Remove replaceLibraries - [`b2ba31e`](https://github.com/PlayCover/PlayCover/commit/b2ba31e10bfc5317c772714a4447c3141c89c4d6) Error checking - [`06944f8`](https://github.com/PlayCover/PlayCover/commit/06944f86245e31daeb5ac861308498c76be71327) SwiftLint - [`a6bc98a`](https://github.com/PlayCover/PlayCover/commit/a6bc98a521c18746744f5ddeec77fc16fdce7976) Endianness fixes - [`5ae6c52`](https://github.com/PlayCover/PlayCover/commit/5ae6c524597df68638e0ec93ae0e1ab9a0a595c1) Ignore file_length - [`471376c`](https://github.com/PlayCover/PlayCover/commit/471376cd8d47bf2fcb940c73ef3b4fee216dead0) Remove debug prints - [`d1be5e9`](https://github.com/PlayCover/PlayCover/commit/d1be5e99a42d576354d6953d9d50c6dd53bfcad6) Make functions shorter ### 📊 Changes **9 files changed** (+357 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+4 -0) 📝 `PlayCover/AppInstaller/Installer.swift` (+0 -1) 📝 `PlayCover/Model/PlayApp.swift` (+1 -1) 📝 `PlayCover/PlayCoverError.swift` (+3 -0) ➕ `PlayCover/Utils/DataExtensions.swift` (+29 -0) 📝 `PlayCover/Utils/FileExtensions.swift` (+0 -1) 📝 `PlayCover/Utils/PlayTools.swift` (+314 -59) 📝 `PlayCover/Utils/URLExtensions.swift` (+5 -2) 📝 `PlayCover/en.lproj/Localizable.strings` (+1 -0) </details> ### 📄 Description **Change:** - Replaces all uses of Xcode CLI with our own implementations, based on `inject` - Installing Xcode CLI would no longer be required after this PR `install_name_tool` usage not converted cause it's not necessary afaik I will leave removing the UI and backend surrounding Xcode CLI to another PR so that the changes from this one can easily be tested in isolation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:08:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1718
No description provided.