[PR #685] [MERGED] Escape forwards slash #1710

New issue

Closed

opened 2026-03-03 19:08:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/685
Author: @TheMoonThatRises
Created: 1/6/2023
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @Depal1

Base: develop ← Head: fix/fmslashesc

📝 Commits (1)

610ae30 fix: escape forward slash

📊 Changes

12 files changed (+28 additions, -15 deletions)

View changed files

📝 PlayCover/AppInstaller/Installer.swift (+2 -2)
📝 PlayCover/AppInstaller/Utils/IPA.swift (+1 -1)
📝 PlayCover/Model/AppContainer.swift (+1 -1)
📝 PlayCover/Model/AppSettings.swift (+2 -1)
📝 PlayCover/Model/BaseApp.swift (+1 -1)
📝 PlayCover/Model/PlayApp.swift (+2 -2)
📝 PlayCover/Utils/DeletePreferences.swift (+2 -2)
📝 PlayCover/Utils/GenshinUserData/DeleteStoredGenshinUserData.swift (+1 -1)
📝 PlayCover/Utils/GenshinUserData/RestoreGenshinUserData.swift (+1 -1)
📝 PlayCover/Utils/GenshinUserData/SaveGenshinUserData.swift (+2 -2)
📝 PlayCover/Utils/Shell.swift (+1 -1)
📝 PlayCover/Utils/URLExtensions.swift (+12 -0)

📄 Description

Adds a new extension function that escapes certain characters when appending a path component. The only time this function needs to be used is when an inputted name can potentially contain a forward slash. Fixes an issue where apps with a forward slash in their display name are unable to be installed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/685 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 1/6/2023 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/fmslashesc` --- ### 📝 Commits (1) - [`610ae30`](https://github.com/PlayCover/PlayCover/commit/610ae307dc722162a1a2d51cb27a863498de4549) fix: escape forward slash ### 📊 Changes **12 files changed** (+28 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/AppInstaller/Installer.swift` (+2 -2) 📝 `PlayCover/AppInstaller/Utils/IPA.swift` (+1 -1) 📝 `PlayCover/Model/AppContainer.swift` (+1 -1) 📝 `PlayCover/Model/AppSettings.swift` (+2 -1) 📝 `PlayCover/Model/BaseApp.swift` (+1 -1) 📝 `PlayCover/Model/PlayApp.swift` (+2 -2) 📝 `PlayCover/Utils/DeletePreferences.swift` (+2 -2) 📝 `PlayCover/Utils/GenshinUserData/DeleteStoredGenshinUserData.swift` (+1 -1) 📝 `PlayCover/Utils/GenshinUserData/RestoreGenshinUserData.swift` (+1 -1) 📝 `PlayCover/Utils/GenshinUserData/SaveGenshinUserData.swift` (+2 -2) 📝 `PlayCover/Utils/Shell.swift` (+1 -1) 📝 `PlayCover/Utils/URLExtensions.swift` (+12 -0) </details> ### 📄 Description Adds a new extension function that escapes certain characters when appending a path component. The only time this function needs to be used is when an inputted name can potentially contain a forward slash. Fixes an issue where apps with a forward slash in their display name are unable to be installed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>