[PR #653] [CLOSED] Add `force_unwrapping` rule to SwiftLint #1698

New issue

Closed

opened 2026-03-03 19:08:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/653
Author: @IsaacMarovitz
Created: 12/29/2022
Status: ❌ Closed

Base: develop ← Head: force-unwraps

📝 Commits (5)

ea39e27 Add force_unwrapping rule to SwiftLint
f48c398 Remove a bunch of force unwraps
9946e9a Bye-bye more force unwraps
db4083e More force unwraps
80ec393 Remaining force unwraps

📊 Changes

18 files changed (+195 additions, -152 deletions)

View changed files

📝 .swiftlint.yml (+3 -3)
📝 PlayCover/AppInstaller/Downloader.swift (+19 -17)
📝 PlayCover/AppInstaller/Utils/Entitlements.swift (+2 -2)
📝 PlayCover/Model/AppInfo.swift (+12 -19)
📝 PlayCover/Model/PlayApp.swift (+0 -7)
📝 PlayCover/Model/PlayRules.swift (+2 -2)
📝 PlayCover/Utils/AppIntegrity.swift (+7 -5)
📝 PlayCover/Utils/FileExtensions.swift (+3 -2)
📝 PlayCover/Utils/Shell.swift (+39 -31)
📝 PlayCover/ViewModel/StoreVM.swift (+32 -18)
📝 PlayCover/Views/App Views/StoreAppView.swift (+2 -2)
📝 PlayCover/Views/MainView.swift (+10 -4)
📝 PlayCover/Views/MenuBarView.swift (+19 -11)
📝 PlayCover/Views/PlayCoverApp.swift (+1 -1)
📝 PlayCover/Views/Settings/IPASourceSettings.swift (+25 -15)
📝 PlayCover/Views/Sidebar Views/AppLibraryView.swift (+14 -10)
📝 PlayCover/Views/SigningSetupView.swift (+4 -2)
📝 PlayCover/Views/Uninstaller.swift (+1 -1)

📄 Description

TODO:

Split view detection function is currently broken

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/653 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 12/29/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `force-unwraps` --- ### 📝 Commits (5) - [`ea39e27`](https://github.com/PlayCover/PlayCover/commit/ea39e278804989067b805c05520761a9303d90f3) Add `force_unwrapping` rule to SwiftLint - [`f48c398`](https://github.com/PlayCover/PlayCover/commit/f48c398cbbf0e0748d5482529088406d88418dc6) Remove a bunch of force unwraps - [`9946e9a`](https://github.com/PlayCover/PlayCover/commit/9946e9ac3898683de927be50de5a1bfcb0e18dca) Bye-bye more force unwraps - [`db4083e`](https://github.com/PlayCover/PlayCover/commit/db4083e6241e75ab7be5d17d401dccd91cfe8bc3) More force unwraps - [`80ec393`](https://github.com/PlayCover/PlayCover/commit/80ec3930b97fba5f8021a54d64cdf5cb5b9fa7c8) Remaining force unwraps ### 📊 Changes **18 files changed** (+195 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `.swiftlint.yml` (+3 -3) 📝 `PlayCover/AppInstaller/Downloader.swift` (+19 -17) 📝 `PlayCover/AppInstaller/Utils/Entitlements.swift` (+2 -2) 📝 `PlayCover/Model/AppInfo.swift` (+12 -19) 📝 `PlayCover/Model/PlayApp.swift` (+0 -7) 📝 `PlayCover/Model/PlayRules.swift` (+2 -2) 📝 `PlayCover/Utils/AppIntegrity.swift` (+7 -5) 📝 `PlayCover/Utils/FileExtensions.swift` (+3 -2) 📝 `PlayCover/Utils/Shell.swift` (+39 -31) 📝 `PlayCover/ViewModel/StoreVM.swift` (+32 -18) 📝 `PlayCover/Views/App Views/StoreAppView.swift` (+2 -2) 📝 `PlayCover/Views/MainView.swift` (+10 -4) 📝 `PlayCover/Views/MenuBarView.swift` (+19 -11) 📝 `PlayCover/Views/PlayCoverApp.swift` (+1 -1) 📝 `PlayCover/Views/Settings/IPASourceSettings.swift` (+25 -15) 📝 `PlayCover/Views/Sidebar Views/AppLibraryView.swift` (+14 -10) 📝 `PlayCover/Views/SigningSetupView.swift` (+4 -2) 📝 `PlayCover/Views/Uninstaller.swift` (+1 -1) </details> ### 📄 Description **TODO:** - [ ] Split view detection function is currently broken --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>