[PR #625] [MERGED] Fancy IPA Library #1689

Closed
opened 2026-03-03 19:08:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/625
Author: @amirsaam
Created: 12/24/2022
Status: Merged
Merged: 1/16/2023
Merged by: @Depal1

Base: preview-fancy-libraryHead: Reworked-Fancy


📝 Commits (10+)

  • c0b5d38 Reworked Fancy Library
  • 6d10916 Merge branch 'develop' into Reworked-Fancy
  • 462a9e4 Merge branch 'PlayCover:develop' into Reworked-Fancy
  • 7c4a9b9 Merge branch 'PlayCover:develop' into Reworked-Fancy
  • 5e2898b Merge branch 'develop' into Reworked-Fancy
  • 5494f18 cleanup and update
  • 46205c0 yeah, typical me pushing code signs :iaminpain:
  • 3597a18 Merge branch 'PlayCover:develop' into Reworked-Fancy
  • 6421b3a No VersionAlert in DetailedView
  • a193ab8 small fixes

📊 Changes

10 files changed (+542 additions, -112 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+8 -0)
📝 PlayCover/Utils/Cacher.swift (+20 -2)
PlayCover/Utils/ViewExtenstions.swift (+56 -0)
📝 PlayCover/ViewModel/StoreVM.swift (+1 -1)
PlayCover/Views/App Views/DetailStoreAppView.swift (+295 -0)
📝 PlayCover/Views/App Views/PlayAppView.swift (+13 -6)
📝 PlayCover/Views/App Views/StoreAppView.swift (+25 -16)
📝 PlayCover/Views/MenuBarView.swift (+1 -1)
📝 PlayCover/Views/Sidebar Views/IPALibraryView.swift (+108 -86)
📝 PlayCover/en.lproj/Localizable.strings (+15 -0)

📄 Description

Reworked Fancy IPA Library
THIS PR NO LONGER REQUIRES MACOS 13 AS PREVIOUSLY NEEDED

All descriptions already have been given in #588
Separated that PR into multiple parts

  • AppDetailedView base design is from @IsaacMarovitz
  • I reworked it, fixed issues, improved its compatibility, added download states, added locale and etc.

THIS NOTE SHOULD BE READ:

  • New StackNavigationView view extension has been introduced in ViewExtenstions.swift that is similar to NavigationStack on macOS 13 but supports macOS 12.
  • So DetailedView is accessible in macOS 12 with the same code with no if #available statement.

This extension can be used in any other views as you may want.
For example: Creating App Folders in App Library or Source Folders in IPA Library

Co-Authored-By: Isaac Marovitz 42140194+IsaacMarovitz@users.noreply.github.com


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/625 **Author:** [@amirsaam](https://github.com/amirsaam) **Created:** 12/24/2022 **Status:** ✅ Merged **Merged:** 1/16/2023 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `preview-fancy-library` ← **Head:** `Reworked-Fancy` --- ### 📝 Commits (10+) - [`c0b5d38`](https://github.com/PlayCover/PlayCover/commit/c0b5d38c7a58fb38f668af001c7ffc1874d1d3ac) Reworked Fancy Library - [`6d10916`](https://github.com/PlayCover/PlayCover/commit/6d1091675a47d98c15c1b5b987306a0743056eae) Merge branch 'develop' into Reworked-Fancy - [`462a9e4`](https://github.com/PlayCover/PlayCover/commit/462a9e4bbe0607290318fbb3e9c99f534b6a00de) Merge branch 'PlayCover:develop' into Reworked-Fancy - [`7c4a9b9`](https://github.com/PlayCover/PlayCover/commit/7c4a9b9f5708eb7d9899b49366e9374dde588e90) Merge branch 'PlayCover:develop' into Reworked-Fancy - [`5e2898b`](https://github.com/PlayCover/PlayCover/commit/5e2898bdc15acdcee618d8f1fcd43b42bdc132e0) Merge branch 'develop' into Reworked-Fancy - [`5494f18`](https://github.com/PlayCover/PlayCover/commit/5494f1808cce9af160ef55216d3cd8ed782eedf3) cleanup and update - [`46205c0`](https://github.com/PlayCover/PlayCover/commit/46205c07d2d0a2e6e2b9451edeb13b97ed70e9c5) yeah, typical me pushing code signs :iaminpain: - [`3597a18`](https://github.com/PlayCover/PlayCover/commit/3597a180bedf2e003c40591f5aa6700b3c6c110d) Merge branch 'PlayCover:develop' into Reworked-Fancy - [`6421b3a`](https://github.com/PlayCover/PlayCover/commit/6421b3aa5bcfda2ca6afb985e955d106ba1355c0) No VersionAlert in DetailedView - [`a193ab8`](https://github.com/PlayCover/PlayCover/commit/a193ab8a60b23f0c1e2e1b39545767dd48fed9c0) small fixes ### 📊 Changes **10 files changed** (+542 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+8 -0) 📝 `PlayCover/Utils/Cacher.swift` (+20 -2) ➕ `PlayCover/Utils/ViewExtenstions.swift` (+56 -0) 📝 `PlayCover/ViewModel/StoreVM.swift` (+1 -1) ➕ `PlayCover/Views/App Views/DetailStoreAppView.swift` (+295 -0) 📝 `PlayCover/Views/App Views/PlayAppView.swift` (+13 -6) 📝 `PlayCover/Views/App Views/StoreAppView.swift` (+25 -16) 📝 `PlayCover/Views/MenuBarView.swift` (+1 -1) 📝 `PlayCover/Views/Sidebar Views/IPALibraryView.swift` (+108 -86) 📝 `PlayCover/en.lproj/Localizable.strings` (+15 -0) </details> ### 📄 Description _Reworked Fancy IPA Library_ **THIS PR NO LONGER REQUIRES MACOS 13 AS PREVIOUSLY NEEDED** All descriptions already have been given in #588 _Separated that PR into multiple parts_ - `AppDetailedView` base design is from @IsaacMarovitz - I reworked it, fixed issues, improved its compatibility, added download states, added locale and etc. _THIS NOTE SHOULD BE READ:_ - New `StackNavigationView` view extension has been introduced in `ViewExtenstions.swift` that is similar to `NavigationStack` on macOS 13 but supports macOS 12. - So `DetailedView` is accessible in macOS 12 with the same code with no `if #available` statement. This extension can be used in any other views as you may want. For example: Creating App Folders in App Library or Source Folders in IPA Library Co-Authored-By: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:08:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1689
No description provided.