[PR #621] [MERGED] Optional ToastView Show + Display Name of the App/Game in Download State #1684

Closed
opened 2026-03-03 19:08:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/621
Author: @amirsaam
Created: 12/24/2022
Status: Merged
Merged: 12/24/2022
Merged by: @Depal1

Base: developHead: Optional-ToastView


📝 Commits (4)

  • 972a720 Optional Show + Name of App being Downloading
  • 92d6b2b fix used locale key
  • 3abb7fc Update Localizable.strings
  • aac18ac Update ToastView.swift

📊 Changes

3 files changed (+48 additions, -44 deletions)

View changed files

📝 PlayCover/ViewModel/ToastVM.swift (+1 -0)
📝 PlayCover/Views/ToastView.swift (+46 -43)
📝 PlayCover/en.lproj/Localizable.strings (+1 -1)

📄 Description

  • Makes ToastView be controllable via isShown boolean in its ViewModel
  • Shows the name of the app/game that is being downloaded

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/621 **Author:** [@amirsaam](https://github.com/amirsaam) **Created:** 12/24/2022 **Status:** ✅ Merged **Merged:** 12/24/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `Optional-ToastView` --- ### 📝 Commits (4) - [`972a720`](https://github.com/PlayCover/PlayCover/commit/972a7208233844a81a0e33dfe3065cf6accd25c3) Optional Show + Name of App being Downloading - [`92d6b2b`](https://github.com/PlayCover/PlayCover/commit/92d6b2b232a5a5f6354b70e250e0bffd66aa7d62) fix used locale key - [`3abb7fc`](https://github.com/PlayCover/PlayCover/commit/3abb7fc589d6b7a18952be1e66ff7a55c420d202) Update Localizable.strings - [`aac18ac`](https://github.com/PlayCover/PlayCover/commit/aac18ace438e7a60df8a1ab30678db8f2f8f8425) Update ToastView.swift ### 📊 Changes **3 files changed** (+48 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/ViewModel/ToastVM.swift` (+1 -0) 📝 `PlayCover/Views/ToastView.swift` (+46 -43) 📝 `PlayCover/en.lproj/Localizable.strings` (+1 -1) </details> ### 📄 Description - Makes ToastView be controllable via `isShown` boolean in its ViewModel - Shows the name of the app/game that is being downloaded --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:08:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1684
No description provided.