[PR #602] [MERGED] fix!: Remove quotations in fetchEntitlements completely #1674

New issue

Closed

opened 2026-03-03 19:08:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/602
Author: @ohaiibuzzle
Created: 12/20/2022
Status: ✅ Merged
Merged: 12/20/2022
Merged by: @Depal1

Base: develop ← Head: fix/remove-fetchEntitlements-quotes

📝 Commits (1)

6234664 fix!: Remove quotations in fetchEntitlements completely

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 PlayCover/Utils/PlayTools.swift (+1 -1)

📄 Description

Since we already escape strings in #600 it would probably be better to simply remove the single quotes completely as the string is already escaped. This also helps if the app name legitimately has the ' character (eg. Hide 'n Seek)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/602 **Author:** [@ohaiibuzzle](https://github.com/ohaiibuzzle) **Created:** 12/20/2022 **Status:** ✅ Merged **Merged:** 12/20/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/remove-fetchEntitlements-quotes` --- ### 📝 Commits (1) - [`6234664`](https://github.com/PlayCover/PlayCover/commit/62346646660cadaf5f088353b33492462337366a) fix!: Remove quotations in fetchEntitlements completely ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Utils/PlayTools.swift` (+1 -1) </details> ### 📄 Description Since we already escape strings in #600 it would probably be better to simply remove the single quotes completely as the string is already escaped. This also helps if the app name legitimately has the `'` character (eg. Hide 'n Seek) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>