[PR #571] [CLOSED] Feat: Define More Data in Sources #1663

New issue

Closed

opened 2026-03-03 19:08:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/571
Author: @amirsaam
Created: 12/13/2022
Status: ❌ Closed

Base: develop ← Head: pt-in-source

📝 Commits (7)

108f93e Feat: Define Installing PlayTools in Source
c24121b Update Cartfile.resolved
2eac566 Update project.pbxproj
7392657 Swiftlint?
bab903c swiftlint line_length
66df8e7 better line_length handling
4fd9f6d More Swiftlint Error, What a PR 👽

📊 Changes

6 files changed (+55 additions, -36 deletions)

View changed files

📝 PlayCover/AppInstaller/Installer.swift (+4 -1)
📝 PlayCover/ViewModel/StoreVM.swift (+1 -0)
📝 PlayCover/Views/App Views/StoreAppView.swift (+15 -10)
📝 PlayCover/Views/MenuBarView.swift (+21 -16)
📝 PlayCover/Views/PlayCoverApp.swift (+1 -1)
📝 PlayCover/Views/Sidebar Views/AppLibraryView.swift (+13 -8)

📄 Description

This PR adds more data required from Sources

noPlayTools Boolean as a data to tell PlayCover Installer whether PlayTools should be installed into the app or not
disabledSIP Boolean that informs user whom tries to install an app that works only in SIP disabled environment

Better to be not merged until 2.1.0 release as it will change Source Structure JSON

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/571 **Author:** [@amirsaam](https://github.com/amirsaam) **Created:** 12/13/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `pt-in-source` --- ### 📝 Commits (7) - [`108f93e`](https://github.com/PlayCover/PlayCover/commit/108f93ecb9d487e3024e55895cbd0148550117fd) Feat: Define Installing PlayTools in Source - [`c24121b`](https://github.com/PlayCover/PlayCover/commit/c24121be71b3d0126ae4f111f28c8e50530cad8d) Update Cartfile.resolved - [`2eac566`](https://github.com/PlayCover/PlayCover/commit/2eac56625d95438e9e19febe671dd12df62557b1) Update project.pbxproj - [`7392657`](https://github.com/PlayCover/PlayCover/commit/7392657491a08543f4f876b398696cb698dabf63) Swiftlint? - [`bab903c`](https://github.com/PlayCover/PlayCover/commit/bab903ce90e5bd6a138182f51a5e4058bb0d3375) swiftlint line_length - [`66df8e7`](https://github.com/PlayCover/PlayCover/commit/66df8e7c177c8ffcc08d65e25cc1155dd8cb8d82) better line_length handling - [`4fd9f6d`](https://github.com/PlayCover/PlayCover/commit/4fd9f6db12f64d37b377b21e20ddf984481e5da5) More Swiftlint Error, What a PR :alien: ### 📊 Changes **6 files changed** (+55 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/AppInstaller/Installer.swift` (+4 -1) 📝 `PlayCover/ViewModel/StoreVM.swift` (+1 -0) 📝 `PlayCover/Views/App Views/StoreAppView.swift` (+15 -10) 📝 `PlayCover/Views/MenuBarView.swift` (+21 -16) 📝 `PlayCover/Views/PlayCoverApp.swift` (+1 -1) 📝 `PlayCover/Views/Sidebar Views/AppLibraryView.swift` (+13 -8) </details> ### 📄 Description This PR adds more data required from Sources - [x] noPlayTools `Boolean` as a data to tell PlayCover Installer whether PlayTools should be installed into the app or not - [ ] disabledSIP `Boolean` that informs user whom tries to install an app that works only in SIP disabled environment Better to be not merged until `2.1.0` release as it will change Source Structure JSON --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>