[PR #517] [MERGED] Remove keymap checks #1648

New issue

Closed

opened 2026-03-03 19:08:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/517
Author: @ZhichGaming
Created: 11/16/2022
Status: ✅ Merged
Merged: 12/10/2022
Merged by: @Depal1

Base: develop ← Head: remove-keymap-checks

📝 Commits (7)

7c671d9 Adding choice to continue keymap import
9b40b2a Localisation conformance
eb12b60 Fix swiftlint
91ab4f1 Move extention to keymapping, return bool
9e17bd9 Changed confirmation message
18c449d Private function
bd4b98c Merge branch 'develop' into remove-keymap-checks

📊 Changes

2 files changed (+34 additions, -7 deletions)

View changed files

📝 PlayCover/Model/Keymapping.swift (+32 -7)
📝 PlayCover/en.lproj/Localizable.strings (+2 -0)

📄 Description

Removes forcing the user to rename their keymap and instead gives them the option to proceed with the import.
Screen Shot 2022-11-16 at 2 12 40 AM

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/517 **Author:** [@ZhichGaming](https://github.com/ZhichGaming) **Created:** 11/16/2022 **Status:** ✅ Merged **Merged:** 12/10/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `remove-keymap-checks` --- ### 📝 Commits (7) - [`7c671d9`](https://github.com/PlayCover/PlayCover/commit/7c671d9436c0b6e0069c46d1bdf7595a5d6dbc30) Adding choice to continue keymap import - [`9b40b2a`](https://github.com/PlayCover/PlayCover/commit/9b40b2a54fe5aa69fa48e34fc846c8553b83ceac) Localisation conformance - [`eb12b60`](https://github.com/PlayCover/PlayCover/commit/eb12b601cebe02d37a4f239233a7024268a139e1) Fix swiftlint - [`91ab4f1`](https://github.com/PlayCover/PlayCover/commit/91ab4f1eb7c6760353a58de14bbf0b0d62020045) Move extention to keymapping, return bool - [`9e17bd9`](https://github.com/PlayCover/PlayCover/commit/9e17bd993258e4b8d9417c7daa09a139b24a59ce) Changed confirmation message - [`18c449d`](https://github.com/PlayCover/PlayCover/commit/18c449db93037db82e22ead22af290fd779e8cc3) Private function - [`bd4b98c`](https://github.com/PlayCover/PlayCover/commit/bd4b98cd37388de054e71f7b34c5e3c610dab023) Merge branch 'develop' into remove-keymap-checks ### 📊 Changes **2 files changed** (+34 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/Keymapping.swift` (+32 -7) 📝 `PlayCover/en.lproj/Localizable.strings` (+2 -0) </details> ### 📄 Description Removes forcing the user to rename their keymap and instead gives them the option to proceed with the import. <img width="372" alt="Screen Shot 2022-11-16 at 2 12 40 AM" src="https://user-images.githubusercontent.com/93055907/202110919-c27cc01c-148a-4d66-94d7-7fcffddbed03.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>