[PR #405] [MERGED] Fix keymapping not updating #1602

New issue

Closed

opened 2026-03-03 19:07:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/405
Author: @TheMoonThatRises
Created: 10/6/2022
Status: ✅ Merged
Merged: 10/9/2022
Merged by: @Depal1

Base: develop ← Head: fix/updatekeymap

📝 Commits (1)

4261b0b fix: async keymap

📊 Changes

1 file changed (+23 additions, -34 deletions)

View changed files

📝 PlayCover/Model/Keymapping.swift (+23 -34)

📄 Description

Fixes #403. The reason why the keymapping would not update is because the keymap variable that PlayCover uses is not synced with the keymap file, as it only reads the file when decoding. This can be solved by having the keymap variable directly return the file's content, which eliminates the problem of the variable being out of sync, and removes the use of the decoder and encoder function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/405 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 10/6/2022 **Status:** ✅ Merged **Merged:** 10/9/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/updatekeymap` --- ### 📝 Commits (1) - [`4261b0b`](https://github.com/PlayCover/PlayCover/commit/4261b0bc4aac1bc57b9a5d21873d36b1560b7403) fix: async keymap ### 📊 Changes **1 file changed** (+23 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/Keymapping.swift` (+23 -34) </details> ### 📄 Description Fixes #403. The reason why the keymapping would not update is because the keymap variable that PlayCover uses is not synced with the keymap file, as it only reads the file when decoding. This can be solved by having the keymap variable directly return the file's content, which eliminates the problem of the variable being out of sync, and removes the use of the decoder and encoder function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>