[PR #371] [CLOSED] Adding keymapping download #1594

New issue

Closed

opened 2026-03-03 19:07:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/371
Author: @ZhichGaming
Created: 9/22/2022
Status: ❌ Closed

Base: develop ← Head: keymapping

📝 Commits (10+)

a304f90 IPASourceSettings
9211423 Link validator
6b3e715 Status badges
a2a187e Fix behaviour of move up/move down
876f4bf Resolve sources
435f569 Source list works with IPA library (Search bar not working rn)
a1ef616 IPA Library now searchable
9664f18 Add “Resolve Sources” command/shortcut
22e06d5 Locale compliance
358482b Adding Download keymap button

📊 Changes

67 files changed (+3284 additions, -1369 deletions)

View changed files

📝 .github/workflows/1.build_release.yml (+1 -1)
📝 .github/workflows/2.nightly_release.yml (+1 -1)
📝 .github/workflows/SwiftLint.yml (+1 -1)
📝 Cartfile (+1 -1)
📝 Cartfile.resolved (+1 -1)
📝 PlayCover.xcodeproj/project.pbxproj (+47 -8)
📝 PlayCover/AppInstaller/Installer.swift (+82 -54)
📝 PlayCover/AppInstaller/Utils/Entitlements.swift (+20 -10)
📝 PlayCover/AppInstaller/Utils/IPA.swift (+17 -19)
📝 PlayCover/IntentFlow/UserIntentFlow.swift (+0 -5)
📝 PlayCover/Model/AppContainer.swift (+3 -6)
📝 PlayCover/Model/AppInfo.swift (+21 -9)
📝 PlayCover/Model/BaseApp.swift (+5 -2)
➕ PlayCover/Model/KeyCodeNames.swift (+100 -0)
📝 PlayCover/Model/Keymapping.swift (+3 -0)
📝 PlayCover/Model/PlayApp.swift (+32 -53)
📝 PlayCover/PlayCoverError.swift (+3 -0)
📝 PlayCover/Utils/AppIntegrity.swift (+2 -4)
📝 PlayCover/Utils/FileExtensions.swift (+1 -1)
📝 PlayCover/Utils/GenshinUserData/DeleteStoredGenshinUserData.swift (+4 -4)

...and 47 more files

📄 Description

Checks if the keymapping for a game exists in the keymaps repository, #368 should be merged first. Repost of #370 since that one had unrelated history.

Add keymaps to PlayCover/keymaps
Modify code to support github repositories instead of Puck json
Add custom sources (After #368 is merged)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/371 **Author:** [@ZhichGaming](https://github.com/ZhichGaming) **Created:** 9/22/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `keymapping` --- ### 📝 Commits (10+) - [`a304f90`](https://github.com/PlayCover/PlayCover/commit/a304f9065a85f859f6dd14f180eac459631366ef) IPASourceSettings - [`9211423`](https://github.com/PlayCover/PlayCover/commit/921142388d17b5bf997c3637b3bc63808454990f) Link validator - [`6b3e715`](https://github.com/PlayCover/PlayCover/commit/6b3e715bae12c8466b5054689871b06bd2410b01) Status badges - [`a2a187e`](https://github.com/PlayCover/PlayCover/commit/a2a187e38719ba30ef4f33f188776fd0f500160f) Fix behaviour of move up/move down - [`876f4bf`](https://github.com/PlayCover/PlayCover/commit/876f4bf93e4e50796e05a022768e4096d51fcddd) Resolve sources - [`435f569`](https://github.com/PlayCover/PlayCover/commit/435f569c67e9476da49d0bebe72672a0d9d7d603) Source list works with IPA library (Search bar not working rn) - [`a1ef616`](https://github.com/PlayCover/PlayCover/commit/a1ef61624f716d14438da390fcc0aa8b94cb79ff) IPA Library now searchable - [`9664f18`](https://github.com/PlayCover/PlayCover/commit/9664f18053f203f60d3c8d26cacfaf1882b16503) Add “Resolve Sources” command/shortcut - [`22e06d5`](https://github.com/PlayCover/PlayCover/commit/22e06d541abb6f0f458612ac1bacd953458de47b) Locale compliance - [`358482b`](https://github.com/PlayCover/PlayCover/commit/358482b3875b581e47f285e4be80f142bd5ccfff) Adding Download keymap button ### 📊 Changes **67 files changed** (+3284 additions, -1369 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/1.build_release.yml` (+1 -1) 📝 `.github/workflows/2.nightly_release.yml` (+1 -1) 📝 `.github/workflows/SwiftLint.yml` (+1 -1) 📝 `Cartfile` (+1 -1) 📝 `Cartfile.resolved` (+1 -1) 📝 `PlayCover.xcodeproj/project.pbxproj` (+47 -8) 📝 `PlayCover/AppInstaller/Installer.swift` (+82 -54) 📝 `PlayCover/AppInstaller/Utils/Entitlements.swift` (+20 -10) 📝 `PlayCover/AppInstaller/Utils/IPA.swift` (+17 -19) 📝 `PlayCover/IntentFlow/UserIntentFlow.swift` (+0 -5) 📝 `PlayCover/Model/AppContainer.swift` (+3 -6) 📝 `PlayCover/Model/AppInfo.swift` (+21 -9) 📝 `PlayCover/Model/BaseApp.swift` (+5 -2) ➕ `PlayCover/Model/KeyCodeNames.swift` (+100 -0) 📝 `PlayCover/Model/Keymapping.swift` (+3 -0) 📝 `PlayCover/Model/PlayApp.swift` (+32 -53) 📝 `PlayCover/PlayCoverError.swift` (+3 -0) 📝 `PlayCover/Utils/AppIntegrity.swift` (+2 -4) 📝 `PlayCover/Utils/FileExtensions.swift` (+1 -1) 📝 `PlayCover/Utils/GenshinUserData/DeleteStoredGenshinUserData.swift` (+4 -4) _...and 47 more files_ </details> ### 📄 Description Checks if the keymapping for a game exists in the keymaps repository, #368 should be merged first. Repost of #370 since that one had unrelated history. - [x] Add keymaps to PlayCover/keymaps - [x] Modify code to support github repositories instead of Puck json - [x] Add custom sources (After #368 is merged) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>