[PR #368] [MERGED] Updated IPA Source Management #1591

New issue

Closed

opened 2026-03-03 19:07:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/368
Author: @IsaacMarovitz
Created: 9/21/2022
Status: ✅ Merged
Merged: 10/10/2022
Merged by: @Depal1

Base: develop ← Head: develop

📝 Commits (10+)

a304f90 IPASourceSettings
9211423 Link validator
6b3e715 Status badges
a2a187e Fix behaviour of move up/move down
876f4bf Resolve sources
435f569 Source list works with IPA library (Search bar not working rn)
a1ef616 IPA Library now searchable
9664f18 Add “Resolve Sources” command/shortcut
22e06d5 Locale compliance
27ab5e9 In-app downloads

📊 Changes

19 files changed (+779 additions, -137 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+12 -0)
📝 PlayCover/AppInstaller/Installer.swift (+5 -1)
📝 PlayCover/Model/AppInfo.swift (+2 -2)
📝 PlayCover/Model/PlayApp.swift (+2 -5)
📝 PlayCover/PlayCoverError.swift (+3 -0)
➕ PlayCover/ViewModel/DownloadVM.swift (+16 -0)
➕ PlayCover/ViewModel/NetworkVM.swift (+94 -0)
📝 PlayCover/ViewModel/StoreVM.swift (+136 -42)
📝 PlayCover/ViewModel/ToastVM.swift (+1 -1)
📝 PlayCover/Views/App Views/StoreAppView.swift (+120 -48)
📝 PlayCover/Views/MainView.swift (+3 -2)
📝 PlayCover/Views/MenuBarView.swift (+9 -0)
📝 PlayCover/Views/PlayCoverApp.swift (+4 -2)
➕ PlayCover/Views/Settings/IPASourceSettings.swift (+263 -0)
📝 PlayCover/Views/Settings/PlayCoverSettingsView.swift (+8 -1)
📝 PlayCover/Views/Sidebar Views/AppLibraryView.swift (+10 -7)
📝 PlayCover/Views/Sidebar Views/IPALibraryView.swift (+57 -26)
📝 PlayCover/Views/ToastView.swift (+16 -0)
📝 PlayCover/en.lproj/Localizable.strings (+18 -0)

📄 Description

https://user-images.githubusercontent.com/42140194/193436833-dc2819ca-d6fc-4d17-a657-5bae5b250d5a.mov

Remove hardcoded .json both for flexability, and for copyright
Allow users to add their own in-app IPA sources
In-app downloads

Other Changes/Bug Fixes:

.app folders will be renamed to match display name at install time. This means apps will now display with the correct name in the dock
Updated the format of IPA Source .jsons, an example of which can be found here
Fixed an issue where duplicate apps in the Containers folder with the same bundle ID would display incorrectly in grid view, but correctly in list view
Fixed an issue where the display name of apps was sometimes equal to ""
Cleaned up App Library and IPA Library views

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/368 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 9/21/2022 **Status:** ✅ Merged **Merged:** 10/10/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`a304f90`](https://github.com/PlayCover/PlayCover/commit/a304f9065a85f859f6dd14f180eac459631366ef) IPASourceSettings - [`9211423`](https://github.com/PlayCover/PlayCover/commit/921142388d17b5bf997c3637b3bc63808454990f) Link validator - [`6b3e715`](https://github.com/PlayCover/PlayCover/commit/6b3e715bae12c8466b5054689871b06bd2410b01) Status badges - [`a2a187e`](https://github.com/PlayCover/PlayCover/commit/a2a187e38719ba30ef4f33f188776fd0f500160f) Fix behaviour of move up/move down - [`876f4bf`](https://github.com/PlayCover/PlayCover/commit/876f4bf93e4e50796e05a022768e4096d51fcddd) Resolve sources - [`435f569`](https://github.com/PlayCover/PlayCover/commit/435f569c67e9476da49d0bebe72672a0d9d7d603) Source list works with IPA library (Search bar not working rn) - [`a1ef616`](https://github.com/PlayCover/PlayCover/commit/a1ef61624f716d14438da390fcc0aa8b94cb79ff) IPA Library now searchable - [`9664f18`](https://github.com/PlayCover/PlayCover/commit/9664f18053f203f60d3c8d26cacfaf1882b16503) Add “Resolve Sources” command/shortcut - [`22e06d5`](https://github.com/PlayCover/PlayCover/commit/22e06d541abb6f0f458612ac1bacd953458de47b) Locale compliance - [`27ab5e9`](https://github.com/PlayCover/PlayCover/commit/27ab5e996d759eb4d05536324639387e94869e80) In-app downloads ### 📊 Changes **19 files changed** (+779 additions, -137 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+12 -0) 📝 `PlayCover/AppInstaller/Installer.swift` (+5 -1) 📝 `PlayCover/Model/AppInfo.swift` (+2 -2) 📝 `PlayCover/Model/PlayApp.swift` (+2 -5) 📝 `PlayCover/PlayCoverError.swift` (+3 -0) ➕ `PlayCover/ViewModel/DownloadVM.swift` (+16 -0) ➕ `PlayCover/ViewModel/NetworkVM.swift` (+94 -0) 📝 `PlayCover/ViewModel/StoreVM.swift` (+136 -42) 📝 `PlayCover/ViewModel/ToastVM.swift` (+1 -1) 📝 `PlayCover/Views/App Views/StoreAppView.swift` (+120 -48) 📝 `PlayCover/Views/MainView.swift` (+3 -2) 📝 `PlayCover/Views/MenuBarView.swift` (+9 -0) 📝 `PlayCover/Views/PlayCoverApp.swift` (+4 -2) ➕ `PlayCover/Views/Settings/IPASourceSettings.swift` (+263 -0) 📝 `PlayCover/Views/Settings/PlayCoverSettingsView.swift` (+8 -1) 📝 `PlayCover/Views/Sidebar Views/AppLibraryView.swift` (+10 -7) 📝 `PlayCover/Views/Sidebar Views/IPALibraryView.swift` (+57 -26) 📝 `PlayCover/Views/ToastView.swift` (+16 -0) 📝 `PlayCover/en.lproj/Localizable.strings` (+18 -0) </details> ### 📄 Description https://user-images.githubusercontent.com/42140194/193436833-dc2819ca-d6fc-4d17-a657-5bae5b250d5a.mov - Remove hardcoded `.json` both for flexability, and for copyright - Allow users to add their own in-app IPA sources - In-app downloads **Other Changes/Bug Fixes:** - `.app` folders will be renamed to match display name at install time. This means apps will now display with the correct name in the dock - Updated the format of IPA Source `.json`s, an example of which can be found [here](https://raw.githubusercontent.com/IsaacMarovitz/PlayCover-IPA-Source-Tests/main/updatedsource.json) - Fixed an issue where duplicate apps in the `Containers` folder with the same bundle ID would display incorrectly in grid view, but correctly in list view - Fixed an issue where the display name of apps was sometimes equal to "" - Cleaned up App Library and IPA Library views --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>