[PR #313] [MERGED] fix: Add framework search path to fix archive fail for release #1569

New issue

Closed

opened 2026-03-03 19:07:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/313
Author: @KhoraLee
Created: 9/7/2022
Status: ✅ Merged
Merged: 9/7/2022
Merged by: @Depal1

Base: develop ← Head: fix/appIcon

📝 Commits (2)

f2f982c refactor: Separate into function that perform image size comparison
a020b8f fix: Add missing framework search path for Release

📊 Changes

2 files changed (+12 additions, -14 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+3 -0)
📝 PlayCover/Model/PlayApp.swift (+9 -14)

📄 Description

I forgot to add CoreUI framework path to release build setting. So this PR will fix that problem.

Also I refactored selecting high resolution icon logic and separated them into function because same code is repetitive in different scope.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/313 **Author:** [@KhoraLee](https://github.com/KhoraLee) **Created:** 9/7/2022 **Status:** ✅ Merged **Merged:** 9/7/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/appIcon` --- ### 📝 Commits (2) - [`f2f982c`](https://github.com/PlayCover/PlayCover/commit/f2f982cb1d18fdb224a11c2a42133ea01a078d7e) refactor: Separate into function that perform image size comparison - [`a020b8f`](https://github.com/PlayCover/PlayCover/commit/a020b8fc946bf72de53ce13f4edd411fda89bdbf) fix: Add missing framework search path for Release ### 📊 Changes **2 files changed** (+12 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+3 -0) 📝 `PlayCover/Model/PlayApp.swift` (+9 -14) </details> ### 📄 Description I forgot to add CoreUI framework path to release build setting. So this PR will fix that problem. Also I refactored selecting high resolution icon logic and separated them into function because same code is repetitive in different scope. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>