[PR #286] [MERGED] fix!: better error handling for shell commands + empty entitlement fix #1549

New issue

Closed

opened 2026-03-03 19:07:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/286
Author: @ohaiibuzzle
Created: 9/3/2022
Status: ✅ Merged
Merged: 9/5/2022
Merged by: @Depal1

Base: develop ← Head: fix/empty-entitlements

📝 Commits (2)

7d40b3b fix!: make errors more verbose on a failed shell command
9aabe0a fix!: handle cases where an app's entitlement is completely empty

📊 Changes

2 files changed (+49 additions, -27 deletions)

View changed files

📝 PlayCover/Utils/PlayTools.swift (+13 -3)
📝 PlayCover/Utils/Shell.swift (+36 -24)

📄 Description

This patch could be breaking stuff elsewhere, please test before merge.

Make shell.sh throws the content of stderr if pipeStdErr is set to false. This allows better error handling and alerting in case a shell command fails to run properly
Handle cases where the app being installed has no entitlement. Partially fixes #214

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/286 **Author:** [@ohaiibuzzle](https://github.com/ohaiibuzzle) **Created:** 9/3/2022 **Status:** ✅ Merged **Merged:** 9/5/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/empty-entitlements` --- ### 📝 Commits (2) - [`7d40b3b`](https://github.com/PlayCover/PlayCover/commit/7d40b3b98e9f1801020e359ee397cb3491262417) fix!: make errors more verbose on a failed shell command - [`9aabe0a`](https://github.com/PlayCover/PlayCover/commit/9aabe0a57385a5620887e432eff2e1a643bd076d) fix!: handle cases where an app's entitlement is completely empty ### 📊 Changes **2 files changed** (+49 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Utils/PlayTools.swift` (+13 -3) 📝 `PlayCover/Utils/Shell.swift` (+36 -24) </details> ### 📄 Description This patch could be breaking stuff elsewhere, please test before merge. - Make `shell.sh` throws the content of `stderr` **if pipeStdErr is set to false**. This allows better error handling and alerting in case a shell command fails to run properly - Handle cases where the app being installed has no entitlement. Partially fixes #214 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>