[PR #250] [MERGED] Improve Xcode Command line tools install UX #1537

New issue

Closed

opened 2026-03-03 19:07:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/250
Author: @Candygoblen123
Created: 8/26/2022
Status: ✅ Merged
Merged: 8/30/2022
Merged by: @Depal1

Base: 2.0-UI ← Head: 2.0-UI

📝 Commits (6)

1b6a088 Improve Xcode cli detection
db5bbde improve Xcode installiation UI
33f722b Merge branch '2.0-UI' of github.com:PlayCover/PlayCover into 2.0-UI
0bfbda9 fix CLT detection with fill versions of Xcode
85adb98 Merge branch '2.0-UI' of github.com:PlayCover/PlayCover into 2.0-UI
1d17e4d Fix merge errors

📊 Changes

3 files changed (+104 additions, -48 deletions)

View changed files

📝 PlayCover/Utils/Shell.swift (+11 -5)
📝 PlayCover/Views/MainView.swift (+88 -40)
📝 PlayCover/en.lproj/Localizable.strings (+5 -3)

📄 Description

Improves Xcode command line tools detection by actually checking if the files are there, regardless of what xcode-select -p tells us

Improve the UI by:

Adding icons for preinstall, success, and failure steps
Playing a sound on successful and errored install
Provide a link to alternate install methods on failure
After install finishes, actually check to make sure that the Command Line tools were installed, and show the error screen if they aren't.

Screenshots:
Screen Shot 2022-08-26 at 10 15 42 AM

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/250 **Author:** [@Candygoblen123](https://github.com/Candygoblen123) **Created:** 8/26/2022 **Status:** ✅ Merged **Merged:** 8/30/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `2.0-UI` ← **Head:** `2.0-UI` --- ### 📝 Commits (6) - [`1b6a088`](https://github.com/PlayCover/PlayCover/commit/1b6a088a6b629e2e5e95402edcd685806a8c73cd) Improve Xcode cli detection - [`db5bbde`](https://github.com/PlayCover/PlayCover/commit/db5bbde4cab48c521e2da9887d21415f5029ad56) improve Xcode installiation UI - [`33f722b`](https://github.com/PlayCover/PlayCover/commit/33f722b789a7a5264921c82427a540c86f727aab) Merge branch '2.0-UI' of github.com:PlayCover/PlayCover into 2.0-UI - [`0bfbda9`](https://github.com/PlayCover/PlayCover/commit/0bfbda98bd1e5f75622b22fc1f9178d7427172de) fix CLT detection with fill versions of Xcode - [`85adb98`](https://github.com/PlayCover/PlayCover/commit/85adb98535e7773f3a6eec323bf889657c744dfa) Merge branch '2.0-UI' of github.com:PlayCover/PlayCover into 2.0-UI - [`1d17e4d`](https://github.com/PlayCover/PlayCover/commit/1d17e4dff9745a45f4ee8bbde2c24ea30b03fddd) Fix merge errors ### 📊 Changes **3 files changed** (+104 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Utils/Shell.swift` (+11 -5) 📝 `PlayCover/Views/MainView.swift` (+88 -40) 📝 `PlayCover/en.lproj/Localizable.strings` (+5 -3) </details> ### 📄 Description Improves Xcode command line tools detection by actually checking if the files are there, regardless of what `xcode-select -p` tells us Improve the UI by: - Adding icons for preinstall, success, and failure steps - Playing a sound on successful and errored install - Provide a link to alternate install methods on failure - After install finishes, actually check to make sure that the Command Line tools were installed, and show the error screen if they aren't. Screenshots: <img width="1061" alt="Screen Shot 2022-08-26 at 10 15 42 AM" src="https://user-images.githubusercontent.com/28193374/186934502-83ba30b7-5b49-4be3-b13a-82c21d04c834.png"> <img width="1061" alt="Screen Shot 2022-08-26 at 10 16 29 AM" src="https://user-images.githubusercontent.com/28193374/186934510-980af497-090b-406d-ac07-bd284dbfc674.png"> <img width="1061" alt="Screen Shot 2022-08-26 at 10 17 20 AM" src="https://user-images.githubusercontent.com/28193374/186934514-f86d3b79-25bf-4b03-88e1-b3f235d995ce.png"> <img width="1061" alt="Screen Shot 2022-08-26 at 10 15 37 AM" src="https://user-images.githubusercontent.com/28193374/186934517-78bfce7e-ba54-498f-9b67-2c4085aa807c.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>