[PR #248] [MERGED] Feat: Fit with notch preset #1536

Closed
opened 2026-03-03 19:07:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/248
Author: @JoseMoreville
Created: 8/25/2022
Status: Merged
Merged: 8/25/2022
Merged by: @Depal1

Base: developHead: hades-dev


📝 Commits (2)

  • 543febe Fix for MacBook 14" with notch
  • 5a91046 Adding case for fit with notch screen on getScreenSizeSelector

📊 Changes

3 files changed (+6 additions, -0 deletions)

View changed files

📝 PlayCover/Utils/ScreenSizeSelector.swift (+2 -0)
📝 PlayCover/Utils/SetScreenSize.swift (+3 -0)
📝 PlayCover/View/AppSettingsView.swift (+1 -0)

📄 Description

This PR aims to fix #201 by adding a window resolution preset. Thanks to @XuYicong and TensorVortex for helping me on test and discovering the size that works best.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/248 **Author:** [@JoseMoreville](https://github.com/JoseMoreville) **Created:** 8/25/2022 **Status:** ✅ Merged **Merged:** 8/25/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `hades-dev` --- ### 📝 Commits (2) - [`543febe`](https://github.com/PlayCover/PlayCover/commit/543febed1038a2e3a8e7c2f0b40cf039eb26ab1d) Fix for MacBook 14" with notch - [`5a91046`](https://github.com/PlayCover/PlayCover/commit/5a9104680506e1a6f254b318b37b742c595dfe2f) Adding case for fit with notch screen on getScreenSizeSelector ### 📊 Changes **3 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Utils/ScreenSizeSelector.swift` (+2 -0) 📝 `PlayCover/Utils/SetScreenSize.swift` (+3 -0) 📝 `PlayCover/View/AppSettingsView.swift` (+1 -0) </details> ### 📄 Description This PR aims to fix #201 by adding a window resolution preset. Thanks to @XuYicong and TensorVortex for helping me on test and discovering the size that works best. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:07:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1536
No description provided.