[PR #232] [MERGED] Fix all the stuff i didnt get done in 2.0.0 ui lol #1528

New issue

Closed

opened 2026-03-03 19:07:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/232
Author: @IsaacMarovitz
Created: 8/22/2022
Status: ✅ Merged
Merged: 8/23/2022
Merged by: @Candygoblen123

Base: 2.0-UI ← Head: 2.0-UI

📝 Commits (10+)

469c472 App Settings overhaul
0c97f68 Fixed appearance of AsyncImage + App Store Data!!!!
160b689 Add @discardableResult
338fd6f Change completion to async/await, and change URL to URL?
644f2f6 Move iTunesResponse struct to seperate file
17b93d8 Move return
bf585a8 Whitespace
462e53c Remove throw
85800fb Codable keymap + bunch of other improvements
540963e Panel titles

📊 Changes

19 files changed (+481 additions, -412 deletions)

View changed files

📝 Cartfile (+1 -1)
📝 Cartfile.resolved (+1 -1)
📝 PlayCover.xcodeproj/project.pbxproj (+11 -3)
📝 PlayCover/AppInstaller/Utils/Entitlements.swift (+34 -5)
📝 PlayCover/Model/AppSettings.swift (+59 -287)
➕ PlayCover/Model/ITunesResponse.swift (+59 -0)
➕ PlayCover/Model/Keymapping.swift (+166 -0)
📝 PlayCover/Model/PlayApp.swift (+6 -2)
📝 PlayCover/PlayCoverError.swift (+6 -14)
📝 PlayCover/Views/App Views/PlayAppView.swift (+17 -14)
📝 PlayCover/Views/App Views/StoreAppView.swift (+50 -22)
📝 PlayCover/Views/AppSettingsView.swift (+34 -31)
📝 PlayCover/Views/Genshin Account Views/ChangeGenshinAccountView.swift (+4 -4)
📝 PlayCover/Views/Genshin Account Views/DeleteGenshinAccountView.swift (+2 -2)
📝 PlayCover/Views/MainView.swift (+2 -3)
📝 PlayCover/Views/MenuBarView.swift (+1 -1)
📝 PlayCover/Views/Sidebar Views/AppLibraryView.swift (+1 -1)
📝 PlayCover/Views/Sidebar Views/IPALibraryView.swift (+2 -2)
📝 PlayCover/en.lproj/Localizable.strings (+25 -19)

📄 Description

Fixing TODOs...
Very Serious Changelog:

Change app settings from a monolithic file to a per-app file stored in the Containers folder
Updated app settings to use a Codable struct for significantly better code readability
Fixed the appearance of AsyncImage and download icon from App Store for up-to-date icons and correct image size
Change keymapping so they are stored in the Containers folder and use Codable
Make 'reset settings' and 'reset keymapping' buttons functional
Finish localising strings

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/232 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 8/22/2022 **Status:** ✅ Merged **Merged:** 8/23/2022 **Merged by:** [@Candygoblen123](https://github.com/Candygoblen123) **Base:** `2.0-UI` ← **Head:** `2.0-UI` --- ### 📝 Commits (10+) - [`469c472`](https://github.com/PlayCover/PlayCover/commit/469c472ec24025845b8c0bfd5dade391114aa329) App Settings overhaul - [`0c97f68`](https://github.com/PlayCover/PlayCover/commit/0c97f68b05457f7ae39455455294e6a72f9522cd) Fixed appearance of AsyncImage + App Store Data!!!! - [`160b689`](https://github.com/PlayCover/PlayCover/commit/160b689712e0037dacfdf4158ca01fed9498e0b7) Add `@discardableResult` - [`338fd6f`](https://github.com/PlayCover/PlayCover/commit/338fd6f22c4baea98a3c79a5de4e44ee8a22f7e2) Change completion to async/await, and change URL to URL? - [`644f2f6`](https://github.com/PlayCover/PlayCover/commit/644f2f6baa126cca7f44eda309015df8055740d7) Move iTunesResponse struct to seperate file - [`17b93d8`](https://github.com/PlayCover/PlayCover/commit/17b93d8e0aaf6272c4fc59ae45a6d35acd93cf2f) Move return - [`bf585a8`](https://github.com/PlayCover/PlayCover/commit/bf585a8a273fbdd4784764394f1aa18bf1f1f7fa) Whitespace - [`462e53c`](https://github.com/PlayCover/PlayCover/commit/462e53cf21e9a53b25c521fbb82c7b6d355b6400) Remove throw - [`85800fb`](https://github.com/PlayCover/PlayCover/commit/85800fb958c073602205e5eb55140832fcb66c1e) Codable keymap + bunch of other improvements - [`540963e`](https://github.com/PlayCover/PlayCover/commit/540963e1772d24a8c9bdcb72b10d576621b016b6) Panel titles ### 📊 Changes **19 files changed** (+481 additions, -412 deletions) <details> <summary>View changed files</summary> 📝 `Cartfile` (+1 -1) 📝 `Cartfile.resolved` (+1 -1) 📝 `PlayCover.xcodeproj/project.pbxproj` (+11 -3) 📝 `PlayCover/AppInstaller/Utils/Entitlements.swift` (+34 -5) 📝 `PlayCover/Model/AppSettings.swift` (+59 -287) ➕ `PlayCover/Model/ITunesResponse.swift` (+59 -0) ➕ `PlayCover/Model/Keymapping.swift` (+166 -0) 📝 `PlayCover/Model/PlayApp.swift` (+6 -2) 📝 `PlayCover/PlayCoverError.swift` (+6 -14) 📝 `PlayCover/Views/App Views/PlayAppView.swift` (+17 -14) 📝 `PlayCover/Views/App Views/StoreAppView.swift` (+50 -22) 📝 `PlayCover/Views/AppSettingsView.swift` (+34 -31) 📝 `PlayCover/Views/Genshin Account Views/ChangeGenshinAccountView.swift` (+4 -4) 📝 `PlayCover/Views/Genshin Account Views/DeleteGenshinAccountView.swift` (+2 -2) 📝 `PlayCover/Views/MainView.swift` (+2 -3) 📝 `PlayCover/Views/MenuBarView.swift` (+1 -1) 📝 `PlayCover/Views/Sidebar Views/AppLibraryView.swift` (+1 -1) 📝 `PlayCover/Views/Sidebar Views/IPALibraryView.swift` (+2 -2) 📝 `PlayCover/en.lproj/Localizable.strings` (+25 -19) </details> ### 📄 Description ![rainbows-cockroach](https://user-images.githubusercontent.com/42140194/186042444-862824f3-b396-4194-a67b-a8358ab04158.gif) *Fixing TODOs...* **Very Serious Changelog:** - [x] Change app settings from a monolithic file to a per-app file stored in the Containers folder - [x] Updated app settings to use a `Codable` struct for significantly better code readability - [x] Fixed the appearance of `AsyncImage` and download icon from App Store for up-to-date icons and correct image size - [x] Change keymapping so they are stored in the Containers folder and use `Codable` - [x] Make 'reset settings' and 'reset keymapping' buttons functional - [x] Finish localising strings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>