[PR #230] [MERGED] 2.0.0 UI Changes #1526

Closed
opened 2026-03-03 19:07:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/230
Author: @IsaacMarovitz
Created: 8/22/2022
Status: Merged
Merged: 8/22/2022
Merged by: @Depal1

Base: 2.0-UIHead: sidebar-ui


📝 Commits (10+)

📊 Changes

37 files changed (+1460 additions, -1735 deletions)

View changed files

Documentation.docc/Documentation.md (+13 -0)
📝 PlayCover.xcodeproj/project.pbxproj (+99 -103)
📝 PlayCover/AppInstaller/Installer.swift (+14 -14)
PlayCover/Documentation.docc/Documentation.md (+13 -0)
📝 PlayCover/Model/AppInfo.swift (+4 -0)
📝 PlayCover/Model/AppSettings.swift (+130 -147)
📝 PlayCover/Model/PlayApp.swift (+3 -3)
PlayCover/Utils/Colors.swift (+0 -20)
📝 PlayCover/Utils/Shell.swift (+0 -1)
PlayCover/View/AppSettingsView.swift (+0 -230)
PlayCover/View/AppsView.swift (+0 -237)
PlayCover/View/InstallSettings.swift (+0 -35)
PlayCover/View/MainView.swift (+0 -179)
PlayCover/View/SetupView.swift (+0 -146)
PlayCover/View/StoreAppView.swift (+0 -52)
PlayCover/View/Style.swift (+0 -57)
PlayCover/ViewModel/AppSettingsVM.swift (+19 -0)
📝 PlayCover/ViewModel/AppsVM.swift (+0 -4)
📝 PlayCover/ViewModel/InstallVM.swift (+18 -27)
📝 PlayCover/ViewModel/StoreVM.swift (+31 -30)

...and 17 more files

📄 Description

PR IS IN PROGRESS:
Now that Wind's PR got merged I'm gonna start work on this. Gonna leave the PR here as a draft as I work so feel free to review, comment, etc.

This will probably take a long time so bear with me.

PR GOALS:

  • Update PlayCover's app UI to be more in line with macOS design principles (as shown in the design by taku)
  • RTL Language support
  • Add new features currently unavailable in the app
  • Clean up code architecture
  • Better locale support (following the system established in #86)
  • No SwiftLint warnings
  • Removal of some dependencies
    • AlertToast
    • SimplyCoreAudio (Handled by #130)

PROGRESS:

  • Initital dump of old UI
  • Implement sidebar
  • Implement App Library toolbar
    • Buttons
    • Search bar
  • Implement IPA Library
    • Initial UI Layout
    • In-app downloads (To be handled in separate pr by Candy)
    • Extensive library
  • Locale compliance

Application folder invisible shortcuts (Bumped to 2.1.0)
Custom entitlements editor (Bumped to 2.1.0)
Home view (Bumped to 2.1.0)

REIMPLEMENTATION STUFF:
(Stuff I've removed that I'll need to add back)

  • Toast
  • Install Progress bar
  • App Library Search bar
  • App Settings View
  • Clear app preferences button
  • 'Move to Applications' folder warning
  • Xcode CLI install
  • Genshin Account Switcher

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/230 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 8/22/2022 **Status:** ✅ Merged **Merged:** 8/22/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `2.0-UI` ← **Head:** `sidebar-ui` --- ### 📝 Commits (10+) - [`b701fad`](https://github.com/PlayCover/PlayCover/commit/b701fad5434ada20c9c419817f31e167b5b07e90) Updated version number - [`dece805`](https://github.com/PlayCover/PlayCover/commit/dece805fac51913b90791e247cb1a262d6e35977) Byebye Colors.swift - [`4b75737`](https://github.com/PlayCover/PlayCover/commit/4b75737fd486b163fd4e5439a7c88dd288c52d33) Byebye AlertToast - [`01c5f1d`](https://github.com/PlayCover/PlayCover/commit/01c5f1d9335de0582e6b18b603924195c0a9f914) Point Documentation button to right place - [`3a65e9b`](https://github.com/PlayCover/PlayCover/commit/3a65e9b9ee63e2d7c7e4f9cd2a9c8c8f4bb95677) Move crash button to menu bar - [`76ae7cd`](https://github.com/PlayCover/PlayCover/commit/76ae7cdfc62def2e75f546bcf89cbb7b7b5321ab) Remove notices bar - [`dd68fe1`](https://github.com/PlayCover/PlayCover/commit/dd68fe18cfb3c50df7bcaa8644c074c470bf3116) Byebye SearchView - [`f3dbffa`](https://github.com/PlayCover/PlayCover/commit/f3dbffa2233a5670bfe302ac3e6d17fdb4255c0a) Merge branch 'PlayCover:develop' into sidebar-ui - [`660e4a9`](https://github.com/PlayCover/PlayCover/commit/660e4a9d452b7ba831c8758e0d02c30fa6ccdac5) Remove SetupView - [`f80898e`](https://github.com/PlayCover/PlayCover/commit/f80898e47b38006c46a3ba0e804b08dc1cdbe544) Merge branch 'sidebar-ui' of https://github.com/IsaacMarovitz/PlayCover into sidebar-ui ### 📊 Changes **37 files changed** (+1460 additions, -1735 deletions) <details> <summary>View changed files</summary> ➕ `Documentation.docc/Documentation.md` (+13 -0) 📝 `PlayCover.xcodeproj/project.pbxproj` (+99 -103) 📝 `PlayCover/AppInstaller/Installer.swift` (+14 -14) ➕ `PlayCover/Documentation.docc/Documentation.md` (+13 -0) 📝 `PlayCover/Model/AppInfo.swift` (+4 -0) 📝 `PlayCover/Model/AppSettings.swift` (+130 -147) 📝 `PlayCover/Model/PlayApp.swift` (+3 -3) ➖ `PlayCover/Utils/Colors.swift` (+0 -20) 📝 `PlayCover/Utils/Shell.swift` (+0 -1) ➖ `PlayCover/View/AppSettingsView.swift` (+0 -230) ➖ `PlayCover/View/AppsView.swift` (+0 -237) ➖ `PlayCover/View/InstallSettings.swift` (+0 -35) ➖ `PlayCover/View/MainView.swift` (+0 -179) ➖ `PlayCover/View/SetupView.swift` (+0 -146) ➖ `PlayCover/View/StoreAppView.swift` (+0 -52) ➖ `PlayCover/View/Style.swift` (+0 -57) ➕ `PlayCover/ViewModel/AppSettingsVM.swift` (+19 -0) 📝 `PlayCover/ViewModel/AppsVM.swift` (+0 -4) 📝 `PlayCover/ViewModel/InstallVM.swift` (+18 -27) 📝 `PlayCover/ViewModel/StoreVM.swift` (+31 -30) _...and 17 more files_ </details> ### 📄 Description **PR IS IN PROGRESS:** Now that Wind's PR got merged I'm gonna start work on this. Gonna leave the PR here as a draft as I work so feel free to review, comment, etc. This will probably take a long time so bear with me. **PR GOALS:** - Update PlayCover's app UI to be more in line with macOS design principles (as shown in the design by taku) - RTL Language support - Add new features currently unavailable in the app - Clean up code architecture - Better locale support (following the system established in #86) - No SwiftLint warnings - Removal of some dependencies - ~~AlertToast~~ - ~~SimplyCoreAudio~~ (Handled by #130) **PROGRESS:** - [x] Initital dump of old UI - [x] Implement sidebar - [x] Implement App Library toolbar - [x] Buttons - [x] Search bar - [ ] Implement IPA Library - [x] Initial UI Layout - [ ] In-app downloads (To be handled in separate pr by Candy) - [ ] Extensive library - [ ] Locale compliance ~~Application folder invisible shortcuts~~ (Bumped to 2.1.0) ~~Custom entitlements editor~~ (Bumped to 2.1.0) ~~Home view~~ (Bumped to 2.1.0) **REIMPLEMENTATION STUFF:** (Stuff I've removed that I'll need to add back) - [x] Toast - [x] Install Progress bar - [x] App Library Search bar - [x] App Settings View - [x] Clear app preferences button - [x] 'Move to Applications' folder warning - [x] Xcode CLI install - [x] Genshin Account Switcher --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:07:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1526
No description provided.