[PR #224] [MERGED] fix: Replace hardcoded string into LocalizedStringKey #1520

New issue

Closed

opened 2026-03-03 19:07:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/224
Author: @KhoraLee
Created: 8/21/2022
Status: ✅ Merged
Merged: 8/21/2022
Merged by: @Depal1

Base: develop ← Head: fix/hardcodedString

📝 Commits (2)

7dd2f89 fix: Replace hardcoded string into LocalizedStringKey
945bbaa style: Rearrange Arabic localization to match other style

📊 Changes

16 files changed (+461 additions, -88 deletions)

View changed files

📝 PlayCover/View/Settings/PlayCoverSettingsView.swift (+1 -1)
📝 PlayCover/View/Settings/UpdateSettings.swift (+2 -2)
📝 PlayCover/ar.lproj/Localizable.strings (+341 -85)
📝 PlayCover/de.lproj/Localizable.strings (+9 -0)
📝 PlayCover/en.lproj/Localizable.strings (+9 -0)
📝 PlayCover/es.lproj/Localizable.strings (+9 -0)
📝 PlayCover/fa-IR.lproj/Localizable.strings (+9 -0)
📝 PlayCover/fr.lproj/Localizable.strings (+9 -0)
📝 PlayCover/id.lproj/Localizable.strings (+9 -0)
📝 PlayCover/it.lproj/Localizable.strings (+9 -0)
📝 PlayCover/ja.lproj/Localizable.strings (+9 -0)
📝 PlayCover/ko.lproj/Localizable.strings (+9 -0)
📝 PlayCover/ru.lproj/Localizable.strings (+9 -0)
📝 PlayCover/vi.lproj/Localizable.strings (+9 -0)
📝 PlayCover/zh-Hans.lproj/Localizable.strings (+9 -0)
📝 PlayCover/zh-Hant.lproj/Localizable.strings (+9 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/224 **Author:** [@KhoraLee](https://github.com/KhoraLee) **Created:** 8/21/2022 **Status:** ✅ Merged **Merged:** 8/21/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/hardcodedString` --- ### 📝 Commits (2) - [`7dd2f89`](https://github.com/PlayCover/PlayCover/commit/7dd2f89dbb317b9ee8d2200fb0e002e7f6df55e8) fix: Replace hardcoded string into LocalizedStringKey - [`945bbaa`](https://github.com/PlayCover/PlayCover/commit/945bbaadd38a714f38f797e164e9e7d2217443a1) style: Rearrange Arabic localization to match other style ### 📊 Changes **16 files changed** (+461 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/View/Settings/PlayCoverSettingsView.swift` (+1 -1) 📝 `PlayCover/View/Settings/UpdateSettings.swift` (+2 -2) 📝 `PlayCover/ar.lproj/Localizable.strings` (+341 -85) 📝 `PlayCover/de.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/en.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/es.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/fa-IR.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/fr.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/id.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/it.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/ja.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/ko.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/ru.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/vi.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/zh-Hans.lproj/Localizable.strings` (+9 -0) 📝 `PlayCover/zh-Hant.lproj/Localizable.strings` (+9 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>