[PR #211] [MERGED] [Enhancement] Enhanced settings view with locale since #202 #1511

New issue

Closed

opened 2026-03-03 19:07:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/211
Author: @Wind-Explorer
Created: 8/20/2022
Status: ✅ Merged
Merged: 8/21/2022
Merged by: @Depal1

Base: develop ← Head: fix/localization-for-new-strings

📝 Commits (6)

24850cd Updated app settings pane with proper locale
faa0aca Merge branch 'develop' of https://github.com/PlayCover/PlayCover into fix/localization-for-new-strings
ed74606 Enhanced locale file formattings by Apple & Xcode
ba56e33 Merge branch 'develop' of https://github.com/PlayCover/PlayCover into fix/localization-for-new-strings
986bef1 Updated locale files
b73a292 Updated chinese locale file

📊 Changes

14 files changed (+4303 additions, -1126 deletions)

View changed files

📝 PlayCover/View/AppSettingsView.swift (+72 -39)
📝 PlayCover/de.lproj/Localizable.strings (+328 -83)
📝 PlayCover/en.lproj/Localizable.strings (+309 -86)
📝 PlayCover/es.lproj/Localizable.strings (+329 -84)
📝 PlayCover/fa-IR.lproj/Localizable.strings (+326 -84)
📝 PlayCover/fr.lproj/Localizable.strings (+326 -84)
📝 PlayCover/id.lproj/Localizable.strings (+324 -82)
📝 PlayCover/it.lproj/Localizable.strings (+326 -84)
📝 PlayCover/ja.lproj/Localizable.strings (+324 -82)
📝 PlayCover/ko.lproj/Localizable.strings (+326 -84)
📝 PlayCover/ru.lproj/Localizable.strings (+326 -83)
📝 PlayCover/vi.lproj/Localizable.strings (+324 -82)
📝 PlayCover/zh-Hans.lproj/Localizable.strings (+335 -85)
📝 PlayCover/zh-Hant.lproj/Localizable.strings (+328 -84)

📄 Description

Added locale strings for new UI text
Tuned the sizing of the 3 big icons in the view
Refined settings view
截屏2022-08-20 下午11 10 06

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/211 **Author:** [@Wind-Explorer](https://github.com/Wind-Explorer) **Created:** 8/20/2022 **Status:** ✅ Merged **Merged:** 8/21/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/localization-for-new-strings` --- ### 📝 Commits (6) - [`24850cd`](https://github.com/PlayCover/PlayCover/commit/24850cd8b9218f16925a6f390505f6ed77409032) Updated app settings pane with proper locale - [`faa0aca`](https://github.com/PlayCover/PlayCover/commit/faa0aca08a55e6ae01610cc907dc0849c22e8502) Merge branch 'develop' of https://github.com/PlayCover/PlayCover into fix/localization-for-new-strings - [`ed74606`](https://github.com/PlayCover/PlayCover/commit/ed7460625e3d25c5bec8f5385a4cba04e6d6c0d7) Enhanced locale file formattings by Apple & Xcode - [`ba56e33`](https://github.com/PlayCover/PlayCover/commit/ba56e339ec1ad35f685e83ab474bf621ed1ba228) Merge branch 'develop' of https://github.com/PlayCover/PlayCover into fix/localization-for-new-strings - [`986bef1`](https://github.com/PlayCover/PlayCover/commit/986bef12636dbd427fd874222fb6b3cc62f0e9f4) Updated locale files - [`b73a292`](https://github.com/PlayCover/PlayCover/commit/b73a2925d82da31abbe2011cbe5f9b79cc8f2042) Updated chinese locale file ### 📊 Changes **14 files changed** (+4303 additions, -1126 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/View/AppSettingsView.swift` (+72 -39) 📝 `PlayCover/de.lproj/Localizable.strings` (+328 -83) 📝 `PlayCover/en.lproj/Localizable.strings` (+309 -86) 📝 `PlayCover/es.lproj/Localizable.strings` (+329 -84) 📝 `PlayCover/fa-IR.lproj/Localizable.strings` (+326 -84) 📝 `PlayCover/fr.lproj/Localizable.strings` (+326 -84) 📝 `PlayCover/id.lproj/Localizable.strings` (+324 -82) 📝 `PlayCover/it.lproj/Localizable.strings` (+326 -84) 📝 `PlayCover/ja.lproj/Localizable.strings` (+324 -82) 📝 `PlayCover/ko.lproj/Localizable.strings` (+326 -84) 📝 `PlayCover/ru.lproj/Localizable.strings` (+326 -83) 📝 `PlayCover/vi.lproj/Localizable.strings` (+324 -82) 📝 `PlayCover/zh-Hans.lproj/Localizable.strings` (+335 -85) 📝 `PlayCover/zh-Hant.lproj/Localizable.strings` (+328 -84) </details> ### 📄 Description Added locale strings for new UI text Tuned the sizing of the 3 big icons in the view Refined settings view <img width="393" alt="截屏2022-08-20 下午11 10 06" src="https://user-images.githubusercontent.com/66894537/185753474-fef64e95-7dc8-43bf-8919-893c608850af.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>