[PR #158] [MERGED] [Enhancement] Improved device picker UI #1490

New issue

Closed

opened 2026-03-03 19:07:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/158
Author: @Wind-Explorer
Created: 8/14/2022
Status: ✅ Merged
Merged: 8/14/2022
Merged by: @Depal1

Base: develop ← Head: develop

📝 Commits (4)

87c4674 Added new keys to localisations
807ba1a Merge branch 'develop' of https://github.com/PlayCover/PlayCover into fix/add-new-string-keys
f2bdb4b Added key strings for clear preferences
ea59a1b Modified iOS device picker style

📊 Changes

12 files changed (+27 additions, -8 deletions)

View changed files

📝 PlayCover/View/AppSettingsView.swift (+5 -5)
📝 PlayCover/de.lproj/Localizable.strings (+2 -0)
📝 PlayCover/en.lproj/Localizable.strings (+2 -2)
📝 PlayCover/es.lproj/Localizable.strings (+2 -1)
📝 PlayCover/fr.lproj/Localizable.strings (+2 -0)
📝 PlayCover/id.lproj/Localizable.strings (+2 -0)
📝 PlayCover/it.lproj/Localizable.strings (+2 -0)
📝 PlayCover/ja.lproj/Localizable.strings (+2 -0)
📝 PlayCover/ko.lproj/Localizable.strings (+2 -0)
📝 PlayCover/ru.lproj/Localizable.strings (+2 -0)
📝 PlayCover/vi.lproj/Localizable.strings (+2 -0)
📝 PlayCover/zh-Hans.lproj/Localizable.strings (+2 -0)

📄 Description

Interface for other locales were broken without the new keys added for each locale hence this PR solves the issue as well as modifying picker style for future-proof

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/158 **Author:** [@Wind-Explorer](https://github.com/Wind-Explorer) **Created:** 8/14/2022 **Status:** ✅ Merged **Merged:** 8/14/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (4) - [`87c4674`](https://github.com/PlayCover/PlayCover/commit/87c4674f49143805e8fbcbadd9a66fa0882d5e74) Added new keys to localisations - [`807ba1a`](https://github.com/PlayCover/PlayCover/commit/807ba1ada5f0748000dabbbb1398d9afcab8925c) Merge branch 'develop' of https://github.com/PlayCover/PlayCover into fix/add-new-string-keys - [`f2bdb4b`](https://github.com/PlayCover/PlayCover/commit/f2bdb4b277b36cb78a3ce55137f1886264d5be70) Added key strings for clear preferences - [`ea59a1b`](https://github.com/PlayCover/PlayCover/commit/ea59a1bd63b8ca61d4fc7747926326cf54dea081) Modified iOS device picker style ### 📊 Changes **12 files changed** (+27 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/View/AppSettingsView.swift` (+5 -5) 📝 `PlayCover/de.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/en.lproj/Localizable.strings` (+2 -2) 📝 `PlayCover/es.lproj/Localizable.strings` (+2 -1) 📝 `PlayCover/fr.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/id.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/it.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/ja.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/ko.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/ru.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/vi.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/zh-Hans.lproj/Localizable.strings` (+2 -0) </details> ### 📄 Description Interface for other locales were broken without the new keys added for each locale hence this PR solves the issue as well as modifying picker style for future-proof --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>