[PR #150] [MERGED] feature: ✨ Now you can switch between Ipad models on app settings. #1487

New issue

Closed

opened 2026-03-03 19:07:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/150
Author: @JoseMoreville
Created: 8/12/2022
Status: ✅ Merged
Merged: 8/12/2022
Merged by: @JoseMoreville

Base: develop ← Head: hades-dev

📝 Commits (1)

d428bf1 Adding iPad model picker

📊 Changes

4 files changed (+23 additions, -2 deletions)

View changed files

📝 PlayCover/Model/AppSettings.swift (+13 -1)
📝 PlayCover/View/AppSettingsView.swift (+7 -0)
📝 PlayCover/View/PlayAppView.swift (+2 -1)
📝 PlayCover/en.lproj/Localizable.strings (+1 -0)

📄 Description

Like the title says, this PR aims to add a picker on app settings to let the user select an ipad pro model to run the app on.
The models I added are Ipad pro 1st, 3rd and 5th gen. I plan to add iphone later but I still have to think in a way to avoid problems with this.

This PR needs https://github.com/PlayCover/PlayTools/pull/13 to work

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/150 **Author:** [@JoseMoreville](https://github.com/JoseMoreville) **Created:** 8/12/2022 **Status:** ✅ Merged **Merged:** 8/12/2022 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `hades-dev` --- ### 📝 Commits (1) - [`d428bf1`](https://github.com/PlayCover/PlayCover/commit/d428bf116934e32ec235612ebd17cdc74fee9d8a) Adding iPad model picker ### 📊 Changes **4 files changed** (+23 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/AppSettings.swift` (+13 -1) 📝 `PlayCover/View/AppSettingsView.swift` (+7 -0) 📝 `PlayCover/View/PlayAppView.swift` (+2 -1) 📝 `PlayCover/en.lproj/Localizable.strings` (+1 -0) </details> ### 📄 Description Like the title says, this PR aims to add a picker on app settings to let the user select an ipad pro model to run the app on. The models I added are Ipad pro 1st, 3rd and 5th gen. I plan to add iphone later but I still have to think in a way to avoid problems with this. This PR needs https://github.com/PlayCover/PlayTools/pull/13 to work --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>