[PR #149] [MERGED] Fixed Encrypted Mach-O detection #1485

New issue

Closed

opened 2026-03-03 19:07:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/149
Author: @ohaiibuzzle
Created: 8/11/2022
Status: ✅ Merged
Merged: 8/11/2022
Merged by: @Depal1

Base: develop ← Head: fix/detect-encryption

📝 Commits (1)

ea92602 fix: Correcting encrypted IPA detection

📊 Changes

1 file changed (+3 additions, -6 deletions)

View changed files

📝 PlayCover/Utils/PlayTools.swift (+3 -6)

📄 Description

The old function splits the output content with a newline, which essentially make the second contains to always be false, as they are not on the same line invtool's output, so this check will always return false, even for IPAs that are encrypted

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/149 **Author:** [@ohaiibuzzle](https://github.com/ohaiibuzzle) **Created:** 8/11/2022 **Status:** ✅ Merged **Merged:** 8/11/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/detect-encryption` --- ### 📝 Commits (1) - [`ea92602`](https://github.com/PlayCover/PlayCover/commit/ea92602e1408fad279d1b171a56c0a0a5202d17b) fix: Correcting encrypted IPA detection ### 📊 Changes **1 file changed** (+3 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Utils/PlayTools.swift` (+3 -6) </details> ### 📄 Description The old function splits the output content with a newline, which essentially make the second `contains` to always be `false`, as they are not on the same line in`vtool`'s output, so this check will always return `false`, even for IPAs that are encrypted --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>