[PR #130] [MERGED] refactor: Reimplement SoundDeviceService with CoreAudio #1474

New issue

Closed

opened 2026-03-03 19:07:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/130
Author: @KhoraLee
Created: 8/1/2022
Status: ✅ Merged
Merged: 8/1/2022
Merged by: @Depal1

Base: develop ← Head: refatcor/audio

📝 Commits (1)

e0ffa99 refactor: Reimplement SoundDeviceService with CoreAudio

📊 Changes

13 files changed (+74 additions, -25 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+0 -17)
📝 PlayCover/Services/SoundDeviceService.swift (+62 -7)
📝 PlayCover/de.lproj/Localizable.strings (+1 -0)
📝 PlayCover/en.lproj/Localizable.strings (+1 -0)
📝 PlayCover/es.lproj/Localizable.strings (+1 -0)
📝 PlayCover/fr.lproj/Localizable.strings (+2 -1)
📝 PlayCover/id.lproj/Localizable.strings (+1 -0)
📝 PlayCover/it.lproj/Localizable.strings (+1 -0)
📝 PlayCover/ja.lproj/Localizable.strings (+1 -0)
📝 PlayCover/ko.lproj/Localizable.strings (+1 -0)
📝 PlayCover/ru.lproj/Localizable.strings (+1 -0)
📝 PlayCover/vi.lproj/Localizable.strings (+1 -0)
📝 PlayCover/zh-Hans.lproj/Localizable.strings (+1 -0)

📄 Description

This PR will get rid of SimplyCoreAudio dependency and reimplement SoundDeviceService with Apple's CoreAudio.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/130 **Author:** [@KhoraLee](https://github.com/KhoraLee) **Created:** 8/1/2022 **Status:** ✅ Merged **Merged:** 8/1/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `refatcor/audio` --- ### 📝 Commits (1) - [`e0ffa99`](https://github.com/PlayCover/PlayCover/commit/e0ffa993b6f3dac0b0c2a9244844d3696c563f11) refactor: Reimplement SoundDeviceService with CoreAudio ### 📊 Changes **13 files changed** (+74 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+0 -17) 📝 `PlayCover/Services/SoundDeviceService.swift` (+62 -7) 📝 `PlayCover/de.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/en.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/es.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/fr.lproj/Localizable.strings` (+2 -1) 📝 `PlayCover/id.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/it.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/ja.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/ko.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/ru.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/vi.lproj/Localizable.strings` (+1 -0) 📝 `PlayCover/zh-Hans.lproj/Localizable.strings` (+1 -0) </details> ### 📄 Description This PR will get rid of [SimplyCoreAudio](https://github.com/rnine/SimplyCoreAudio) dependency and reimplement `SoundDeviceService` with Apple's CoreAudio. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>