[PR #121] [MERGED] (related to #86) Updating string keys for AppView.swift #1469

New issue

Closed

opened 2026-03-03 19:07:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/121
Author: @Wind-Explorer
Created: 7/31/2022
Status: ✅ Merged
Merged: 7/31/2022
Merged by: @Depal1

Base: develop ← Head: feature/revamped-string-keys

📝 Commits (10+)

8c1cd03 Replaced all strings with keys
b8d9368 Wiped all previous translations
4f3d9ce Tuned code for proper building
0e7f62f Attempting to resolve conflict
5557e9a Reverted whatever I just did
c3940d8 nuked all conflicts - ready to merge
dc5d006 ;-; forgot to stage a file
3f83d5c Resolve more conflicts
72feef1 resolving EVEN more conflicts (DEPALLL!!!!)
a717cbc Updated locales to work with #91

📊 Changes

14 files changed (+46 additions, -26 deletions)

View changed files

📝 PlayCover/View/AppSettingsView.swift (+2 -2)
📝 PlayCover/View/AppsView.swift (+13 -15)
📝 PlayCover/View/SetupView.swift (+9 -9)
📝 PlayCover/de.lproj/Localizable.strings (+2 -0)
📝 PlayCover/en.lproj/Localizable.strings (+2 -0)
📝 PlayCover/es.lproj/Localizable.strings (+2 -0)
📝 PlayCover/fr.lproj/Localizable.strings (+2 -0)
📝 PlayCover/id.lproj/Localizable.strings (+2 -0)
📝 PlayCover/it.lproj/Localizable.strings (+2 -0)
📝 PlayCover/ja.lproj/Localizable.strings (+2 -0)
📝 PlayCover/ko.lproj/Localizable.strings (+2 -0)
📝 PlayCover/ru.lproj/Localizable.strings (+2 -0)
📝 PlayCover/vi.lproj/Localizable.strings (+2 -0)
📝 PlayCover/zh-Hans.lproj/Localizable.strings (+2 -0)

📄 Description

I am certain that I have updated the file in #86 before but maybe the changes are lost during rebase or resolving conflicts. This PR brings back the lost changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/121 **Author:** [@Wind-Explorer](https://github.com/Wind-Explorer) **Created:** 7/31/2022 **Status:** ✅ Merged **Merged:** 7/31/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `feature/revamped-string-keys` --- ### 📝 Commits (10+) - [`8c1cd03`](https://github.com/PlayCover/PlayCover/commit/8c1cd035c90532e150a795ede4d81e3789053fbf) Replaced all strings with keys - [`b8d9368`](https://github.com/PlayCover/PlayCover/commit/b8d9368aa793c2fd07e0c86f29c1c7dbe7466edc) Wiped all previous translations - [`4f3d9ce`](https://github.com/PlayCover/PlayCover/commit/4f3d9ce9b379767b89057ff994cd5cddbb3ef9e0) Tuned code for proper building - [`0e7f62f`](https://github.com/PlayCover/PlayCover/commit/0e7f62ffa6f154bb168abbdcc63a2e104bdb667b) Attempting to resolve conflict - [`5557e9a`](https://github.com/PlayCover/PlayCover/commit/5557e9a8ccd045281f8a9dd809bbdd5f2a6fdc41) Reverted whatever I just did - [`c3940d8`](https://github.com/PlayCover/PlayCover/commit/c3940d820ee6141b4bd3513f27023d8f6f58713e) nuked all conflicts - ready to merge - [`dc5d006`](https://github.com/PlayCover/PlayCover/commit/dc5d00619b2bd8f8459cf6688c35c479735f573f) ;-; forgot to stage a file - [`3f83d5c`](https://github.com/PlayCover/PlayCover/commit/3f83d5cd4cddb08724dd533527ab4e61a24618ee) Resolve more conflicts - [`72feef1`](https://github.com/PlayCover/PlayCover/commit/72feef1d2eee25dd9f8192b43e27f05e831ca099) resolving EVEN more conflicts (DEPALLL!!!!) - [`a717cbc`](https://github.com/PlayCover/PlayCover/commit/a717cbc6091dc6530dc7025f31716f9c8e39f1d7) Updated locales to work with #91 ### 📊 Changes **14 files changed** (+46 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/View/AppSettingsView.swift` (+2 -2) 📝 `PlayCover/View/AppsView.swift` (+13 -15) 📝 `PlayCover/View/SetupView.swift` (+9 -9) 📝 `PlayCover/de.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/en.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/es.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/fr.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/id.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/it.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/ja.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/ko.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/ru.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/vi.lproj/Localizable.strings` (+2 -0) 📝 `PlayCover/zh-Hans.lproj/Localizable.strings` (+2 -0) </details> ### 📄 Description I am certain that I have updated the file in #86 before but maybe the changes are lost during rebase or resolving conflicts. This PR brings back the lost changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>