[PR #120] [MERGED] fix: Update account switcher UI #1467

New issue

Closed

opened 2026-03-03 19:07:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/120
Author: @Candygoblen123
Created: 7/31/2022
Status: ✅ Merged
Merged: 7/31/2022
Merged by: @JoseMoreville

Base: develop ← Head: develop

📝 Commits (3)

0a8e253 fix: crash when user never opened genshin before trying to save their account
68af885 fix: improved UI of genshin account switcher
9587d52 Merge branch 'develop' of github.com:PlayCover/PlayCover into develop

📊 Changes

9 files changed (+140 additions, -105 deletions)

View changed files

📝 PlayCover/PlayCoverError.swift (+4 -0)
📝 PlayCover/Utils/DeleteStoredGenshinUserData.swift (+1 -1)
📝 PlayCover/Utils/RestoreGenshinUserData.swift (+29 -24)
📝 PlayCover/Utils/SaveGenshinUserData.swift (+31 -25)
📝 PlayCover/Utils/Shell.swift (+2 -2)
📝 PlayCover/View/ChangeGenshinAccountView.swift (+18 -13)
📝 PlayCover/View/DeleteGenshinStoredAccountView.swift (+17 -9)
📝 PlayCover/View/PlayAppView.swift (+6 -9)
📝 PlayCover/View/StoreGenshinAccountView.swift (+32 -22)

📄 Description

require all fields to be filled out before the store button becomes available
add "Exit" button to store account sheet
switch from using pill-shaped buttons to using system-like buttons
add confirmation and warning when deleting an account
add confirmation and warning that restoring an account will override the currently signed-in account
fixed a force try crash when users tried to store an account without opening the game for the first time
removed various swiftlint:disable comments that didn't make much sense, and fixed the listing errors

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/120 **Author:** [@Candygoblen123](https://github.com/Candygoblen123) **Created:** 7/31/2022 **Status:** ✅ Merged **Merged:** 7/31/2022 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (3) - [`0a8e253`](https://github.com/PlayCover/PlayCover/commit/0a8e2530b01c2a9ac8e7e223407427e3f2f46648) fix: crash when user never opened genshin before trying to save their account - [`68af885`](https://github.com/PlayCover/PlayCover/commit/68af8859ebca704a4764270e9342701b0cea3a5f) fix: improved UI of genshin account switcher - [`9587d52`](https://github.com/PlayCover/PlayCover/commit/9587d52f11dadce0d720c8952e48646a5d52683c) Merge branch 'develop' of github.com:PlayCover/PlayCover into develop ### 📊 Changes **9 files changed** (+140 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/PlayCoverError.swift` (+4 -0) 📝 `PlayCover/Utils/DeleteStoredGenshinUserData.swift` (+1 -1) 📝 `PlayCover/Utils/RestoreGenshinUserData.swift` (+29 -24) 📝 `PlayCover/Utils/SaveGenshinUserData.swift` (+31 -25) 📝 `PlayCover/Utils/Shell.swift` (+2 -2) 📝 `PlayCover/View/ChangeGenshinAccountView.swift` (+18 -13) 📝 `PlayCover/View/DeleteGenshinStoredAccountView.swift` (+17 -9) 📝 `PlayCover/View/PlayAppView.swift` (+6 -9) 📝 `PlayCover/View/StoreGenshinAccountView.swift` (+32 -22) </details> ### 📄 Description - require all fields to be filled out before the store button becomes available - add "Exit" button to store account sheet - switch from using pill-shaped buttons to using system-like buttons - add confirmation and warning when deleting an account - add confirmation and warning that restoring an account will override the currently signed-in account - fixed a force try crash when users tried to store an account without opening the game for the first time - removed various `swiftlint:disable` comments that didn't make much sense, and fixed the listing errors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>