[PR #117] [CLOSED] Fix shell crash #1464

Closed
opened 2026-03-03 19:07:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/117
Author: @IsaacMarovitz
Created: 7/30/2022
Status: Closed

Base: masterHead: develop


📝 Commits (10+)

  • 7336de5 spelling and grammar
  • c2c11cd fixed: Change the update url to fit new update file format
  • e29eafc Improved icon scaling
  • bb41f9a Merge pull request #39 from zanderp25/develop
  • 031ac76 Add 2022 M2 Macbook Air to Notched macs.
  • 9641c75 Merge pull request #44 from Dippyskoodlez/patch-1
  • 45cf5ae Merge pull request #37 from ohaiibuzzle/fix/update
  • 4e78acc add improved updater
  • 4061d49 create changelog view in app
  • 860410b fix updater runtime warnings and nicer changelog UI

📊 Changes

101 files changed (+2242 additions, -1464 deletions)

View changed files

.github/workflows/2.nightly_release.yml (+60 -0)
.github/workflows/SwiftLint.yml (+20 -0)
📝 .gitignore (+1 -0)
.swiftlint.yml (+12 -0)
📝 Cartfile.resolved (+1 -1)
📝 PlayCover.xcodeproj/project.pbxproj (+89 -20)
📝 PlayCover/AppInstaller/Installer.swift (+18 -18)
📝 PlayCover/AppInstaller/Utils/Entitlements.swift (+43 -44)
📝 PlayCover/AppInstaller/Utils/IPA.swift (+17 -15)
📝 PlayCover/AppInstaller/Utils/TempAllocator.swift (+16 -15)
📝 PlayCover/AppInstaller/Utils/Unarchiver.swift (+7 -6)
PlayCover/Assets.xcassets/AppIcon.appiconset/1024.png (+0 -0)
PlayCover/Assets.xcassets/AppIcon.appiconset/128.png (+0 -0)
PlayCover/Assets.xcassets/AppIcon.appiconset/16.png (+0 -0)
PlayCover/Assets.xcassets/AppIcon.appiconset/256.png (+0 -0)
PlayCover/Assets.xcassets/AppIcon.appiconset/32.png (+0 -0)
PlayCover/Assets.xcassets/AppIcon.appiconset/512.png (+0 -0)
PlayCover/Assets.xcassets/AppIcon.appiconset/64.png (+0 -0)
📝 PlayCover/Assets.xcassets/AppIcon.appiconset/Contents.json (+68 -1)
PlayCover/Assets.xcassets/AppIcon.appiconset/Icon-MacOS-128x128@1x.png (+0 -0)

...and 80 more files

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/117 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 7/30/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`7336de5`](https://github.com/PlayCover/PlayCover/commit/7336de53f1ab3038215274ce450b248d2d5ae985) spelling and grammar - [`c2c11cd`](https://github.com/PlayCover/PlayCover/commit/c2c11cdfc6327b5e41303ad485586f14ada9f00f) fixed: Change the update url to fit new update file format - [`e29eafc`](https://github.com/PlayCover/PlayCover/commit/e29eafc561d5db7b4c5e1922b07fbe1b4b1ca348) Improved icon scaling - [`bb41f9a`](https://github.com/PlayCover/PlayCover/commit/bb41f9a7c1968dba25f2f98d29d1c0bd8f2045e9) Merge pull request #39 from zanderp25/develop - [`031ac76`](https://github.com/PlayCover/PlayCover/commit/031ac76cb042ce3ca357220eedc6966145aadaa1) Add 2022 M2 Macbook Air to Notched macs. - [`9641c75`](https://github.com/PlayCover/PlayCover/commit/9641c753ce340d93c7c559e1eb32f2ad3bb25dff) Merge pull request #44 from Dippyskoodlez/patch-1 - [`45cf5ae`](https://github.com/PlayCover/PlayCover/commit/45cf5ae2840c5a93cdad70e69a67499e203835d3) Merge pull request #37 from ohaiibuzzle/fix/update - [`4e78acc`](https://github.com/PlayCover/PlayCover/commit/4e78acc32ea0605b0806a1e72c50812f7f8c00ba) add improved updater - [`4061d49`](https://github.com/PlayCover/PlayCover/commit/4061d49d2ed4d2fa544bf2028ddc806274facbb0) create changelog view in app - [`860410b`](https://github.com/PlayCover/PlayCover/commit/860410b3f55cb7694443c42472da3527f04de839) fix updater runtime warnings and nicer changelog UI ### 📊 Changes **101 files changed** (+2242 additions, -1464 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/2.nightly_release.yml` (+60 -0) ➕ `.github/workflows/SwiftLint.yml` (+20 -0) 📝 `.gitignore` (+1 -0) ➕ `.swiftlint.yml` (+12 -0) 📝 `Cartfile.resolved` (+1 -1) 📝 `PlayCover.xcodeproj/project.pbxproj` (+89 -20) 📝 `PlayCover/AppInstaller/Installer.swift` (+18 -18) 📝 `PlayCover/AppInstaller/Utils/Entitlements.swift` (+43 -44) 📝 `PlayCover/AppInstaller/Utils/IPA.swift` (+17 -15) 📝 `PlayCover/AppInstaller/Utils/TempAllocator.swift` (+16 -15) 📝 `PlayCover/AppInstaller/Utils/Unarchiver.swift` (+7 -6) ➖ `PlayCover/Assets.xcassets/AppIcon.appiconset/1024.png` (+0 -0) ➖ `PlayCover/Assets.xcassets/AppIcon.appiconset/128.png` (+0 -0) ➖ `PlayCover/Assets.xcassets/AppIcon.appiconset/16.png` (+0 -0) ➖ `PlayCover/Assets.xcassets/AppIcon.appiconset/256.png` (+0 -0) ➖ `PlayCover/Assets.xcassets/AppIcon.appiconset/32.png` (+0 -0) ➖ `PlayCover/Assets.xcassets/AppIcon.appiconset/512.png` (+0 -0) ➖ `PlayCover/Assets.xcassets/AppIcon.appiconset/64.png` (+0 -0) 📝 `PlayCover/Assets.xcassets/AppIcon.appiconset/Contents.json` (+68 -1) ➕ `PlayCover/Assets.xcassets/AppIcon.appiconset/Icon-MacOS-128x128@1x.png` (+0 -0) _...and 80 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:07:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1464
No description provided.