[PR #95] [MERGED] [May be breaking] Adding option to disable display timeout per-app #1457

New issue

Closed

opened 2026-03-03 19:07:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/95
Author: @ohaiibuzzle
Created: 7/24/2022
Status: ✅ Merged
Merged: 7/31/2022
Merged by: @Depal1

Base: develop ← Head: feat/disable-timeout

📝 Commits (3)

dbee5ad feat!: disabling display sleep per-app
35149a2 chore: remove unused imports
c54cf85 fix: move timeout settings to App Settings

📊 Changes

4 files changed (+53 additions, -2 deletions)

View changed files

📝 PlayCover/Model/AppSettings.swift (+13 -0)
📝 PlayCover/Model/PlayApp.swift (+30 -1)
📝 PlayCover/View/AppSettingsView.swift (+9 -1)
📝 PlayCover/View/PlayAppView.swift (+1 -0)

📄 Description

This feature was suggested in issue #85

This gives the user an option to completely disable display sleep when a specific app is running. However, because of this, we had to change to using NSWorkspace.shared.openApplication to give PlayCover a handler to the running app and enable/disable display sleep accordingly, so this PR is may have unintended issues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/95 **Author:** [@ohaiibuzzle](https://github.com/ohaiibuzzle) **Created:** 7/24/2022 **Status:** ✅ Merged **Merged:** 7/31/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `feat/disable-timeout` --- ### 📝 Commits (3) - [`dbee5ad`](https://github.com/PlayCover/PlayCover/commit/dbee5adcd1844147adf3c3545b865e1debcd66e7) feat!: disabling display sleep per-app - [`35149a2`](https://github.com/PlayCover/PlayCover/commit/35149a22d465114633c6bf4e6713411a29e8d662) chore: remove unused imports - [`c54cf85`](https://github.com/PlayCover/PlayCover/commit/c54cf85479c9d210f77f2989acecda46d493e614) fix: move timeout settings to App Settings ### 📊 Changes **4 files changed** (+53 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/AppSettings.swift` (+13 -0) 📝 `PlayCover/Model/PlayApp.swift` (+30 -1) 📝 `PlayCover/View/AppSettingsView.swift` (+9 -1) 📝 `PlayCover/View/PlayAppView.swift` (+1 -0) </details> ### 📄 Description This feature was suggested in issue #85 This gives the user an option to completely disable display sleep when a specific app is running. However, because of this, we had to change to using `NSWorkspace.shared.openApplication` to give PlayCover a handler to the running app and enable/disable display sleep accordingly, so this PR is may have unintended issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>