[PR #88] [MERGED] fix: Disable swiftlint on build actions and create SwiftLint action #1453

New issue

Closed

opened 2026-03-03 19:07:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/88
Author: @Candygoblen123
Created: 7/22/2022
Status: ✅ Merged
Merged: 7/22/2022
Merged by: @Depal1

Base: develop ← Head: swiftlint

📝 Commits (5)

4d4fb50 Disable swiftlint on build actions
7bcd557 Add swiftlint action
92a211f use strict mode for linting action
aef8a5d fix remaining linting errors
0d86a28 force install of swiftlint to build

📊 Changes

8 files changed (+29 additions, -5 deletions)

View changed files

➕ .github/workflows/SwiftLint.yml (+20 -0)
📝 PlayCover.xcodeproj/project.pbxproj (+1 -1)
📝 PlayCover/Model/AppInfo.swift (+1 -0)
📝 PlayCover/Utils/Colors.swift (+1 -1)
📝 PlayCover/View/AppSettingsView.swift (+1 -1)
📝 PlayCover/View/AppsView.swift (+3 -1)
📝 PlayCover/ViewModel/Log.swift (+1 -1)
📝 fastlane/Fastfile (+1 -0)

📄 Description

this fixes the current build action, and adds a new SwiftLint action

The SwiftLint action runs on PRs and on push

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/88 **Author:** [@Candygoblen123](https://github.com/Candygoblen123) **Created:** 7/22/2022 **Status:** ✅ Merged **Merged:** 7/22/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `swiftlint` --- ### 📝 Commits (5) - [`4d4fb50`](https://github.com/PlayCover/PlayCover/commit/4d4fb50f7d6eafa6cf7312f94f752b6d87963dc4) Disable swiftlint on build actions - [`7bcd557`](https://github.com/PlayCover/PlayCover/commit/7bcd55745e4d18fa20535018e6f6d893c642f898) Add swiftlint action - [`92a211f`](https://github.com/PlayCover/PlayCover/commit/92a211f106a421ed7c815d3039f6a7f43e6b0956) use strict mode for linting action - [`aef8a5d`](https://github.com/PlayCover/PlayCover/commit/aef8a5d47d9c69c5dd48e637891420eff026b006) fix remaining linting errors - [`0d86a28`](https://github.com/PlayCover/PlayCover/commit/0d86a2832976b65014db00a1831a169d63181f21) force install of swiftlint to build ### 📊 Changes **8 files changed** (+29 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/SwiftLint.yml` (+20 -0) 📝 `PlayCover.xcodeproj/project.pbxproj` (+1 -1) 📝 `PlayCover/Model/AppInfo.swift` (+1 -0) 📝 `PlayCover/Utils/Colors.swift` (+1 -1) 📝 `PlayCover/View/AppSettingsView.swift` (+1 -1) 📝 `PlayCover/View/AppsView.swift` (+3 -1) 📝 `PlayCover/ViewModel/Log.swift` (+1 -1) 📝 `fastlane/Fastfile` (+1 -0) </details> ### 📄 Description this fixes the current build action, and adds a new SwiftLint action The SwiftLint action runs on PRs and on push --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>