[PR #83] [MERGED] feat: Add SwiftLint #1451

New issue

Closed

opened 2026-03-03 19:07:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/83
Author: @Candygoblen123
Created: 7/22/2022
Status: ✅ Merged
Merged: 7/22/2022
Merged by: @Depal1

Base: develop ← Head: swiftlint

📝 Commits (5)

d2ba57c add .swiftlint.yml
35672e5 Fix linting issues
1ff44e4 add swiftlint step to Xcode
1235f2c Merge branch 'develop' of https://github.com/PlayCover/PlayCover into swiftlint
4330551 fix a few merge errors

📊 Changes

42 files changed (+956 additions, -875 deletions)

View changed files

➕ .swiftlint.yml (+12 -0)
📝 PlayCover.xcodeproj/project.pbxproj (+18 -0)
📝 PlayCover/AppInstaller/Installer.swift (+18 -18)
📝 PlayCover/AppInstaller/Utils/Entitlements.swift (+43 -44)
📝 PlayCover/AppInstaller/Utils/IPA.swift (+17 -15)
📝 PlayCover/AppInstaller/Utils/TempAllocator.swift (+16 -15)
📝 PlayCover/AppInstaller/Utils/Unarchiver.swift (+7 -6)
📝 PlayCover/IntentFlow/UserIntentFlow.swift (+5 -5)
📝 PlayCover/Model/AppContainer.swift (+25 -23)
📝 PlayCover/Model/AppInfo.swift (+31 -25)
📝 PlayCover/Model/AppSettings.swift (+68 -64)
📝 PlayCover/Model/BaseApp.swift (+14 -14)
📝 PlayCover/Model/InstallApp.swift (+39 -32)
📝 PlayCover/Model/PhysicialApp.swift (+11 -11)
📝 PlayCover/Model/PlayApp.swift (+45 -38)
📝 PlayCover/Model/PlayRules.swift (+7 -9)
📝 PlayCover/Model/StoreApp.swift (+15 -18)
📝 PlayCover/PlayCoverError.swift (+7 -5)
📝 PlayCover/Services/NotifyService.swift (+6 -8)
📝 PlayCover/Services/SoundDeviceService.swift (+10 -8)

...and 22 more files

📄 Description

Please note that unless this PR is up to date with develop, there will be merge conflicts.

adds SwiftLint, and fixes all listing errors, save a few that I disabled listing for because of the complexity of fixing them

also removed most unsafe operations, like force casting, force trying, and force unwrapping

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/83 **Author:** [@Candygoblen123](https://github.com/Candygoblen123) **Created:** 7/22/2022 **Status:** ✅ Merged **Merged:** 7/22/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `swiftlint` --- ### 📝 Commits (5) - [`d2ba57c`](https://github.com/PlayCover/PlayCover/commit/d2ba57ca5f4a7d463aa60011faf3d0e40dc2e3aa) add .swiftlint.yml - [`35672e5`](https://github.com/PlayCover/PlayCover/commit/35672e59479231095aad64c915803ffb8dcaf8a5) Fix linting issues - [`1ff44e4`](https://github.com/PlayCover/PlayCover/commit/1ff44e4aa1ac341778b5b5a78ca3d97427dd9f2f) add swiftlint step to Xcode - [`1235f2c`](https://github.com/PlayCover/PlayCover/commit/1235f2c263ac97304d2a08afc5eb847200d8da37) Merge branch 'develop' of https://github.com/PlayCover/PlayCover into swiftlint - [`4330551`](https://github.com/PlayCover/PlayCover/commit/4330551c811be91373c55417856d0971d6a2da7d) fix a few merge errors ### 📊 Changes **42 files changed** (+956 additions, -875 deletions) <details> <summary>View changed files</summary> ➕ `.swiftlint.yml` (+12 -0) 📝 `PlayCover.xcodeproj/project.pbxproj` (+18 -0) 📝 `PlayCover/AppInstaller/Installer.swift` (+18 -18) 📝 `PlayCover/AppInstaller/Utils/Entitlements.swift` (+43 -44) 📝 `PlayCover/AppInstaller/Utils/IPA.swift` (+17 -15) 📝 `PlayCover/AppInstaller/Utils/TempAllocator.swift` (+16 -15) 📝 `PlayCover/AppInstaller/Utils/Unarchiver.swift` (+7 -6) 📝 `PlayCover/IntentFlow/UserIntentFlow.swift` (+5 -5) 📝 `PlayCover/Model/AppContainer.swift` (+25 -23) 📝 `PlayCover/Model/AppInfo.swift` (+31 -25) 📝 `PlayCover/Model/AppSettings.swift` (+68 -64) 📝 `PlayCover/Model/BaseApp.swift` (+14 -14) 📝 `PlayCover/Model/InstallApp.swift` (+39 -32) 📝 `PlayCover/Model/PhysicialApp.swift` (+11 -11) 📝 `PlayCover/Model/PlayApp.swift` (+45 -38) 📝 `PlayCover/Model/PlayRules.swift` (+7 -9) 📝 `PlayCover/Model/StoreApp.swift` (+15 -18) 📝 `PlayCover/PlayCoverError.swift` (+7 -5) 📝 `PlayCover/Services/NotifyService.swift` (+6 -8) 📝 `PlayCover/Services/SoundDeviceService.swift` (+10 -8) _...and 22 more files_ </details> ### 📄 Description Please note that unless this PR is up to date with develop, there will be merge conflicts. adds SwiftLint, and fixes all listing errors, save a few that I disabled listing for because of the complexity of fixing them also removed most unsafe operations, like force casting, force trying, and force unwrapping --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>