[PR #82] [MERGED] Fixes SoundDeviceService, a deprecation, changes error alert title #1449

New issue

Closed

opened 2026-03-03 19:07:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/82
Author: @IsaacMarovitz
Created: 7/22/2022
Status: ✅ Merged
Merged: 7/22/2022
Merged by: @Depal1

Base: develop ← Head: sound-fix

📝 Commits (8)

f5b49bf Deprecation fixes + SoundDeviceService Fixes
b4925b3 Merge branch 'develop' into sound-fix
4822023 Added NSAlert Dialog
0194648 Localisation stuff
2f38d3c SwiftLint Warnings
1295e9c Update SoundDeviceService.swift
9aecef1 Remove old localisations
95e699f Update PlayCover.xcscheme

📊 Changes

14 files changed (+55 additions, -20 deletions)

View changed files

📝 PlayCover/Services/SoundDeviceService.swift (+12 -12)
📝 PlayCover/View/AppsView.swift (+9 -3)
📝 PlayCover/ViewModel/Log.swift (+1 -1)
📝 PlayCover/de.lproj/Localizable.strings (+3 -0)
📝 PlayCover/en.lproj/Localizable.strings (+3 -0)
📝 PlayCover/es.lproj/Localizable.strings (+3 -1)
📝 PlayCover/fr.lproj/Localizable.strings (+3 -0)
📝 PlayCover/id.lproj/Localizable.strings (+3 -0)
📝 PlayCover/it.lproj/Localizable.strings (+3 -1)
📝 PlayCover/ja.lproj/Localizable.strings (+3 -0)
📝 PlayCover/ko.lproj/Localizable.strings (+3 -0)
📝 PlayCover/ru.lproj/Localizable.strings (+3 -0)
📝 PlayCover/vi.lproj/Localizable.strings (+3 -1)
📝 PlayCover/zh-Hans.lproj/Localizable.strings (+3 -1)

📄 Description

SoundDeviceService will now attempt to change the current output sample rate to 48 KHz
Fixed typos and wording on SoundDeviceService error
Change error dialogue titles from "Some error happened!" to "An Error Occurred!"
Fixed a deprecation warning in Sideloadly export

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/82 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 7/22/2022 **Status:** ✅ Merged **Merged:** 7/22/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `sound-fix` --- ### 📝 Commits (8) - [`f5b49bf`](https://github.com/PlayCover/PlayCover/commit/f5b49bfd208692bb036c91ceed29251fa0f256cc) Deprecation fixes + SoundDeviceService Fixes - [`b4925b3`](https://github.com/PlayCover/PlayCover/commit/b4925b3723a4f095991a426f9a0e2363a82ef04c) Merge branch 'develop' into sound-fix - [`4822023`](https://github.com/PlayCover/PlayCover/commit/4822023c1f122b6ecb7b29d59071f860c25365eb) Added NSAlert Dialog - [`0194648`](https://github.com/PlayCover/PlayCover/commit/0194648c8c277ff11b53b2ef67f0aa32fe40e5de) Localisation stuff - [`2f38d3c`](https://github.com/PlayCover/PlayCover/commit/2f38d3c898cdb9aa4d338c954ce0121b30a7e62b) SwiftLint Warnings - [`1295e9c`](https://github.com/PlayCover/PlayCover/commit/1295e9c15bb7d50228639983ac458d56dfcc987e) Update SoundDeviceService.swift - [`9aecef1`](https://github.com/PlayCover/PlayCover/commit/9aecef1c1d676d6b9c99660e156a650dddea6cf9) Remove old localisations - [`95e699f`](https://github.com/PlayCover/PlayCover/commit/95e699fd9cf3679e1a428e039bd0a8f6c7b6b221) Update PlayCover.xcscheme ### 📊 Changes **14 files changed** (+55 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Services/SoundDeviceService.swift` (+12 -12) 📝 `PlayCover/View/AppsView.swift` (+9 -3) 📝 `PlayCover/ViewModel/Log.swift` (+1 -1) 📝 `PlayCover/de.lproj/Localizable.strings` (+3 -0) 📝 `PlayCover/en.lproj/Localizable.strings` (+3 -0) 📝 `PlayCover/es.lproj/Localizable.strings` (+3 -1) 📝 `PlayCover/fr.lproj/Localizable.strings` (+3 -0) 📝 `PlayCover/id.lproj/Localizable.strings` (+3 -0) 📝 `PlayCover/it.lproj/Localizable.strings` (+3 -1) 📝 `PlayCover/ja.lproj/Localizable.strings` (+3 -0) 📝 `PlayCover/ko.lproj/Localizable.strings` (+3 -0) 📝 `PlayCover/ru.lproj/Localizable.strings` (+3 -0) 📝 `PlayCover/vi.lproj/Localizable.strings` (+3 -1) 📝 `PlayCover/zh-Hans.lproj/Localizable.strings` (+3 -1) </details> ### 📄 Description - SoundDeviceService will now attempt to change the current output sample rate to 48 KHz - Fixed typos and wording on SoundDeviceService error - Change error dialogue titles from "Some error happened!" to "An Error Occurred!" - Fixed a deprecation warning in Sideloadly export --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>