[PR #81] [MERGED] Remove deprecated and unused Objective-C services #1448

New issue

Closed

opened 2026-03-03 19:07:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/81
Author: @IsaacMarovitz
Created: 7/21/2022
Status: ✅ Merged
Merged: 7/24/2022
Merged by: @Depal1

Base: develop ← Head: develop

📝 Commits (9)

99a9bf0 Remove Deprecated and Potentially Parasitic Objective-C
979b7e4 Fixed Deprecation
ce0e873 Merge branch 'develop' of https://github.com/PlayCover/PlayCover into PlayCover-develop
363fd25 Merge branch 'PlayCover:develop' into develop
b5dfbed Merge branch 'PlayCover:develop' into develop
11598e1 Merge remote-tracking branch 'upstream/develop' into develop
a352eeb Merge branch 'PlayCover:develop' into develop
68e3c09 Fixed animation deprecation warning
c9abfca Revert "Fixed animation deprecation warning"

📊 Changes

9 files changed (+0 additions, -159 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+0 -16)
📝 PlayCover/PlayCover-Bridging-Header.h (+0 -2)
➖ PlayCover/Utils/LaunchServicesWrapper.h (+0 -19)
➖ PlayCover/Utils/LaunchServicesWrapper.m (+0 -34)
➖ PlayCover/Utils/LoginKitWrapper.h (+0 -9)
➖ PlayCover/Utils/LoginKitWrapper.m (+0 -18)
➖ PlayCover/Utils/LoginServiceKit.swift (+0 -59)
📝 PlayCover/View/PlayCoverApp.swift (+0 -1)
📝 PlayCover/ViewModel/AppsVM.swift (+0 -1)

📄 Description

Removed LaunchServicesWrapper, which uses a deprecated API to set .ipas to open with PlayCover by default without alerting the user.

Removed LoginKitWrapper, which uses a deprecated API to manage login items, and is unused.

Fixed a deprecation warning.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/81 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 7/21/2022 **Status:** ✅ Merged **Merged:** 7/24/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (9) - [`99a9bf0`](https://github.com/PlayCover/PlayCover/commit/99a9bf075608ed604bc958fda451825c57edb0e5) Remove Deprecated and Potentially Parasitic Objective-C - [`979b7e4`](https://github.com/PlayCover/PlayCover/commit/979b7e40d1304209f845878fbb41d1070bb7fda7) Fixed Deprecation - [`ce0e873`](https://github.com/PlayCover/PlayCover/commit/ce0e8736d64354d7a117a8d40cdddf7c3c7bd57c) Merge branch 'develop' of https://github.com/PlayCover/PlayCover into PlayCover-develop - [`363fd25`](https://github.com/PlayCover/PlayCover/commit/363fd25f5d4db05ecf2d61aa18ac85c617ca316c) Merge branch 'PlayCover:develop' into develop - [`b5dfbed`](https://github.com/PlayCover/PlayCover/commit/b5dfbeda54a97083026e74fb1e8e0000d637e014) Merge branch 'PlayCover:develop' into develop - [`11598e1`](https://github.com/PlayCover/PlayCover/commit/11598e11da21549e686a934172306846d766d451) Merge remote-tracking branch 'upstream/develop' into develop - [`a352eeb`](https://github.com/PlayCover/PlayCover/commit/a352eebef1e80e62e3e6f95ac1c81880fbe847aa) Merge branch 'PlayCover:develop' into develop - [`68e3c09`](https://github.com/PlayCover/PlayCover/commit/68e3c0957312a4e772be1593e7b21c4c22b4fff0) Fixed animation deprecation warning - [`c9abfca`](https://github.com/PlayCover/PlayCover/commit/c9abfcabaedd0746884db6cc5169334e38b8b529) Revert "Fixed animation deprecation warning" ### 📊 Changes **9 files changed** (+0 additions, -159 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+0 -16) 📝 `PlayCover/PlayCover-Bridging-Header.h` (+0 -2) ➖ `PlayCover/Utils/LaunchServicesWrapper.h` (+0 -19) ➖ `PlayCover/Utils/LaunchServicesWrapper.m` (+0 -34) ➖ `PlayCover/Utils/LoginKitWrapper.h` (+0 -9) ➖ `PlayCover/Utils/LoginKitWrapper.m` (+0 -18) ➖ `PlayCover/Utils/LoginServiceKit.swift` (+0 -59) 📝 `PlayCover/View/PlayCoverApp.swift` (+0 -1) 📝 `PlayCover/ViewModel/AppsVM.swift` (+0 -1) </details> ### 📄 Description Removed `LaunchServicesWrapper`, which uses a deprecated API to set `.ipa`s to open with PlayCover by default without alerting the user. Removed `LoginKitWrapper`, which uses a deprecated API to manage login items, and is unused. Fixed a deprecation warning. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>