[PR #32] [CLOSED] Updating localization content #1419

New issue

Closed

opened 2026-03-03 19:06:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:06:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/32
Author: @ohaiibuzzle
Created: 7/14/2022
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (9)

b4b8822 feat: Added localizations to most UI elements
cb055e7 added: the rest of the translatable strings (for PlayCover)
b560835 updated: remove strings related to ldid (not necessary)
71f71c5 updated: remove NSLocalizedString from Buttons (not necessary)
8a8d23d Merge branch 'PlayCover:develop' into develop
1d92794 Merge branch 'develop' of github.com:PlayCover/PlayCover into PlayCover-develop
2a7f657 chore: sync with upstream
2f566cf Merge branch 'PlayCover:develop' into develop
2a50272 Merge branch 'PlayCover:develop' into develop

📊 Changes

9 files changed (+106 additions, -33 deletions)

View changed files

📝 PlayCover/View/AppSettingsView.swift (+7 -7)
📝 PlayCover/View/AppsView.swift (+8 -8)
📝 PlayCover/View/InstallSettings.swift (+1 -1)
📝 PlayCover/View/MainView.swift (+2 -2)
📝 PlayCover/View/PlayCoverApp.swift (+2 -1)
📝 PlayCover/View/SetupView.swift (+5 -5)
📝 PlayCover/ViewModel/InstallVM.swift (+11 -6)
📝 PlayCover/ViewModel/Log.swift (+2 -2)
📝 PlayCover/en.lproj/Localizable.strings (+68 -1)

📄 Description

Added most of the localization content into the English localizable.
This is otherwise identical to #8 but without the NSLocalizableStrings for buttons (as they are automatically handled by Swift)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/32 **Author:** [@ohaiibuzzle](https://github.com/ohaiibuzzle) **Created:** 7/14/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (9) - [`b4b8822`](https://github.com/PlayCover/PlayCover/commit/b4b882244a80e1eb4723e501eefa8b4514424082) feat: Added localizations to most UI elements - [`cb055e7`](https://github.com/PlayCover/PlayCover/commit/cb055e7d0ab911ea10b809c0fcfb4a1a1e255c8f) added: the rest of the translatable strings (for PlayCover) - [`b560835`](https://github.com/PlayCover/PlayCover/commit/b56083559bd83fcd6d8aa9cabbfacbad2ac3996a) updated: remove strings related to ldid (not necessary) - [`71f71c5`](https://github.com/PlayCover/PlayCover/commit/71f71c52ac2a8f1b4ea095573e48e579590871d4) updated: remove NSLocalizedString from Buttons (not necessary) - [`8a8d23d`](https://github.com/PlayCover/PlayCover/commit/8a8d23d202f5c535568706ec3c55b7b12220f8a0) Merge branch 'PlayCover:develop' into develop - [`1d92794`](https://github.com/PlayCover/PlayCover/commit/1d927944ee04b3b20601b9d444e2129fec32b40f) Merge branch 'develop' of github.com:PlayCover/PlayCover into PlayCover-develop - [`2a7f657`](https://github.com/PlayCover/PlayCover/commit/2a7f65749c31be5ab147147b8b8838ca0bfff713) chore: sync with upstream - [`2f566cf`](https://github.com/PlayCover/PlayCover/commit/2f566cff174799cea7e8b6f7ade98c52fbfa5d47) Merge branch 'PlayCover:develop' into develop - [`2a50272`](https://github.com/PlayCover/PlayCover/commit/2a50272aac1dda79ad2dc9f670c00b5d9be9c29c) Merge branch 'PlayCover:develop' into develop ### 📊 Changes **9 files changed** (+106 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/View/AppSettingsView.swift` (+7 -7) 📝 `PlayCover/View/AppsView.swift` (+8 -8) 📝 `PlayCover/View/InstallSettings.swift` (+1 -1) 📝 `PlayCover/View/MainView.swift` (+2 -2) 📝 `PlayCover/View/PlayCoverApp.swift` (+2 -1) 📝 `PlayCover/View/SetupView.swift` (+5 -5) 📝 `PlayCover/ViewModel/InstallVM.swift` (+11 -6) 📝 `PlayCover/ViewModel/Log.swift` (+2 -2) 📝 `PlayCover/en.lproj/Localizable.strings` (+68 -1) </details> ### 📄 Description Added most of the localization content into the English localizable. This is otherwise identical to #8 but without the NSLocalizableStrings for buttons (as they are automatically handled by Swift) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>