mirror of
https://github.com/PlayCover/PlayCover.git
synced 2026-04-27 00:35:52 +03:00
[GH-ISSUE #253] [Feature]: Picture In Picture support #109
Labels
No labels
UI
app-support
bug
bug
documentation
duplicate
enhancement
game-support
good first issue
help wanted / caution
inactive
invalid
macos-beta
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PlayCover#109
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MingyaoLiu on GitHub (Aug 27, 2022).
Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/253
Is your feature request related to a problem?
I have twitch installed and sometimes I can trigger a picture in picture, but not always. So I guess it works just not sure how well it can be supported
Describe the solution you'd like
Best idea I can come up with is having a shortcut or button to trigger picture in picture for whatever content that may or may not support it
Anything else?
not really
Issue Language
@Candygoblen123 commented on GitHub (Aug 27, 2022):
Not much we can really do about this one. Either PIP is available through catalyst (an apple technology) or PIP is not available.
In addition, this isn't exactly a high priority for us.
@MingyaoLiu commented on GitHub (Aug 27, 2022):
@Candygoblen123 yah I understand, I'm just wondering if there is some kind of condition that triggers the picture in picture mode, maybe that condition can be met somehow.
Feel free to close it if it's not important
@KhoraLee commented on GitHub (Aug 29, 2022):
It looks like PIP is supported in catalyst. https://developer.apple.com/documentation/avkit/avpictureinpicturecontroller
@MingyaoLiu commented on GitHub (Aug 29, 2022):
based on @KhoraLee 's link, there is a picture in picture controller that apps can call check whether device support pip?
@Candygoblen123 is it possible to intercept the picture in picture request and return true on all those conditions? might be the way to make pip work for ios app?
@Candygoblen123 commented on GitHub (Aug 29, 2022):
Theoretically yes, but in order to initialize the PIP controller, we would need direct access to the video player object itself. Because we have no idea what the structure of the running app looks like it isn’t easy to get the video player out of the app.
We could take some inspiration from https://github.com/PoomSmart/YouPiP/tree/main, but it would have to be modified to support any app instead of just YouTube
@KhoraLee commented on GitHub (Aug 31, 2022):
@Candygoblen123 I did not tested twitch but nPlayer(Video player)'s pip mode works without any modification.
@Candygoblen123 commented on GitHub (Aug 31, 2022):
I think I see a pip button in that screenshot. Twitch does not have that, it goes into pip when you background the app, which isn’t possible on macOS.
@MingyaoLiu commented on GitHub (Aug 31, 2022):
@KhoraLee that's good to know.
I tried plex which has a PIP button, but it doesn't work on mac.
for twitch on ipad and iphone, it doesn't have pip button, it only goes to pip when swipe to home from full screen view.
@KhoraLee commented on GitHub (Sep 3, 2022):
https://user-images.githubusercontent.com/18005062/188273779-b4ea32c8-05d9-4863-972d-ddf9f0f38441.mp4
@MingyaoLiu I can force enable PIP in twitch but not all app is supported.
For me plex's PIP button is working without problem(on Ventura) and forcing pip mode worked in live videos but not worked in movies and dramas.
But is this feature really needed?
@MingyaoLiu commented on GitHub (Sep 3, 2022):
@KhoraLee what did you click to force PIP in twitch? I don't know how to do it at all.
@KhoraLee commented on GitHub (Sep 3, 2022):
@MingyaoLiu I built my own playtools to inject code.
@MingyaoLiu commented on GitHub (Sep 3, 2022):
@KhoraLee oh nice, yah if you could share what you did, I could learn how to force it as well.
@KhoraLee commented on GitHub (Sep 3, 2022):
@MingyaoLiu
github.com/KhoraLee/PlayTools@0a17d0fc1dThis is how I made force enable pip
@amirsaam commented on GitHub (Sep 3, 2022):
Off topic question, do your Twitch stay logged in when SIP is on?
@KhoraLee commented on GitHub (Sep 3, 2022):
No twitch is always requiring me to login with SIP on
@MingyaoLiu commented on GitHub (Sep 3, 2022):
@amirsaam i have sip disabled always, along with nvram boot change.
@KhoraLee Thanks for the example, I haven't touched ios dev for a couple years, didn't know the way around pip haha. I will try something similar today.
@MingyaoLiu commented on GitHub (Sep 4, 2022):
I added @KhoraLee 's code to my fork of the playtool, then updated carthage to point to my local repo, and build playcover and it's working. A nice little experience to get back to mac dev, a lot of things have changed
@Depal1 commented on GitHub (Sep 14, 2022):
If anyone considers this could be an useful feature, it could be added to PlayCover as a toggle under App Settings > Misc.
@MingyaoLiu commented on GitHub (Sep 14, 2022):
I think that's a good solution to add this to settings, I use it all the time, can't say the same for others.
@IsaacMarovitz commented on GitHub (Oct 7, 2022):
@KhoraLee This feature works on Netflix, please make a PR for the 2.0 branch
@IsaacMarovitz commented on GitHub (Dec 29, 2022):
Stale/ Waiting on updates to PlayTools https://github.com/PlayCover/PlayTools/pull/51