[PR #30] [MERGED] Dev #31

New issue

Closed

opened 2026-03-03 00:05:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:05:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/avikeid2007/Ping-Legacy/pull/30
Author: @avikeid2007
Created: 2/19/2026
Status: ✅ Merged
Merged: 2/19/2026
Merged by: @avikeid2007

Base: master ← Head: dev

📝 Commits (2)

21d2611 Add offline MAC vendor lookup and enhanced network scanner
22fe3e3 Merge pull request #29 from avikeid2007/avi/networkScan

📊 Changes

28 files changed (+40776 additions, -31 deletions)

View changed files

📝 .gitignore (+6 -1)
➕ CHANGES_SUMMARY.md (+215 -0)
➕ MAC_VENDOR_LOOKUP_FIX.md (+244 -0)
📝 NETWORK_SCANNER_IMPLEMENTATION.md (+10 -0)
➕ OUI_DATASET.md (+50 -0)
➕ OUI_LOOKUP_DEBUGGING.md (+157 -0)
➕ PingTool.WinUI3/Assets/oui.csv (+39090 -0)
➕ PingTool.WinUI3/Helpers/NeighborCacheHelper.cs (+100 -0)
📝 PingTool.WinUI3/Helpers/SQLiteHelper.cs (+7 -0)
📝 PingTool.WinUI3/Models/NetworkScanResult.cs (+69 -0)
📝 PingTool.WinUI3/Models/PingTarget.cs (+17 -0)
📝 PingTool.WinUI3/PingTool.WinUI3.csproj (+3 -0)
📝 PingTool.WinUI3/Services/HistoryService.cs (+45 -0)
📝 PingTool.WinUI3/Services/NetworkScannerService.cs (+101 -0)
➕ PingTool.WinUI3/Services/OuiVendorLookupService.cs (+177 -0)
📝 PingTool.WinUI3/ViewModels/MainViewModel.cs (+17 -2)
📝 PingTool.WinUI3/ViewModels/MultiPingViewModel.cs (+2 -2)
📝 PingTool.WinUI3/ViewModels/NetworkScannerViewModel.cs (+6 -3)
📝 PingTool.WinUI3/Views/HistoryPage.xaml (+39 -11)
📝 PingTool.WinUI3/Views/HistoryPage.xaml.cs (+36 -0)

...and 8 more files

📄 Description

This pull request focuses on diagnosing and fixing issues with MAC vendor lookup in the network scanner feature. The main changes introduce comprehensive debug logging, clarify the expected OUI database format and build steps, and add new helper utilities and settings to support MAC address and vendor resolution. These improvements will help identify why vendor names are not appearing and ensure the lookup works reliably for local network scans.

Diagnostics and Debugging Improvements:

Added detailed debug logging to OuiVendorLookupService covering database loading, lookup attempts, and error handling. This enables step-by-step tracing of why vendor names might show as "Unknown vendor" during scans. [1] [2]

Documentation and Troubleshooting:

Added MAC_VENDOR_LOOKUP_FIX.md, CHANGES_SUMMARY.md, and OUI_LOOKUP_DEBUGGING.md with step-by-step guides, troubleshooting, verification commands, and explanations of the OUI lookup process and dataset requirements. These docs help developers and users verify the presence, format, and build configuration of the OUI database. [1] [2] [3]
Added OUI_DATASET.md to explain why the repo ships an empty oui.csv, how to generate/import a compliant OUI dataset, and how to ensure it's included in the app.

Feature and Model Enhancements:

Updated the network scan result model and settings to include optional MacAddress and Vendor fields, and a LookupMacVendor setting to control vendor lookup. This prepares the app to display enriched scan results. [1] [2]

Codebase Utilities:

Introduced NeighborCacheHelper to retrieve MAC addresses for local IPv4 devices by querying the Windows ARP/neighbor cache, supporting accurate MAC-to-vendor mapping.
Added a utility method ClearAllPingMessages() to SQLiteHelper for clearing ping message records, supporting easier database management during testing or troubleshooting.

These changes collectively improve the reliability, transparency, and supportability of MAC vendor lookups in the application, making it easier to diagnose and permanently resolve related issues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/avikeid2007/Ping-Legacy/pull/30 **Author:** [@avikeid2007](https://github.com/avikeid2007) **Created:** 2/19/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@avikeid2007](https://github.com/avikeid2007) **Base:** `master` ← **Head:** `dev` --- ### 📝 Commits (2) - [`21d2611`](https://github.com/avikeid2007/Ping-Legacy/commit/21d2611911c58a5bcdf03c82c07adc332baaa2b8) Add offline MAC vendor lookup and enhanced network scanner - [`22fe3e3`](https://github.com/avikeid2007/Ping-Legacy/commit/22fe3e369f07ed23b9561e70e759a74c7e424005) Merge pull request #29 from avikeid2007/avi/networkScan ### 📊 Changes **28 files changed** (+40776 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+6 -1) ➕ `CHANGES_SUMMARY.md` (+215 -0) ➕ `MAC_VENDOR_LOOKUP_FIX.md` (+244 -0) 📝 `NETWORK_SCANNER_IMPLEMENTATION.md` (+10 -0) ➕ `OUI_DATASET.md` (+50 -0) ➕ `OUI_LOOKUP_DEBUGGING.md` (+157 -0) ➕ `PingTool.WinUI3/Assets/oui.csv` (+39090 -0) ➕ `PingTool.WinUI3/Helpers/NeighborCacheHelper.cs` (+100 -0) 📝 `PingTool.WinUI3/Helpers/SQLiteHelper.cs` (+7 -0) 📝 `PingTool.WinUI3/Models/NetworkScanResult.cs` (+69 -0) 📝 `PingTool.WinUI3/Models/PingTarget.cs` (+17 -0) 📝 `PingTool.WinUI3/PingTool.WinUI3.csproj` (+3 -0) 📝 `PingTool.WinUI3/Services/HistoryService.cs` (+45 -0) 📝 `PingTool.WinUI3/Services/NetworkScannerService.cs` (+101 -0) ➕ `PingTool.WinUI3/Services/OuiVendorLookupService.cs` (+177 -0) 📝 `PingTool.WinUI3/ViewModels/MainViewModel.cs` (+17 -2) 📝 `PingTool.WinUI3/ViewModels/MultiPingViewModel.cs` (+2 -2) 📝 `PingTool.WinUI3/ViewModels/NetworkScannerViewModel.cs` (+6 -3) 📝 `PingTool.WinUI3/Views/HistoryPage.xaml` (+39 -11) 📝 `PingTool.WinUI3/Views/HistoryPage.xaml.cs` (+36 -0) _...and 8 more files_ </details> ### 📄 Description This pull request focuses on diagnosing and fixing issues with MAC vendor lookup in the network scanner feature. The main changes introduce comprehensive debug logging, clarify the expected OUI database format and build steps, and add new helper utilities and settings to support MAC address and vendor resolution. These improvements will help identify why vendor names are not appearing and ensure the lookup works reliably for local network scans. **Diagnostics and Debugging Improvements:** * Added detailed debug logging to `OuiVendorLookupService` covering database loading, lookup attempts, and error handling. This enables step-by-step tracing of why vendor names might show as "Unknown vendor" during scans. [[1]](diffhunk://#diff-154752f844a11e0cdaa4ecdb16a62e64f1741d4210c6bf03bbbb61cf6574e0b6R1-R215) [[2]](diffhunk://#diff-c4e0fecdd41c84145207d0b99b1483ee33c6f8736899d3c693b1ef233b9b766fR1-R157) **Documentation and Troubleshooting:** * Added `MAC_VENDOR_LOOKUP_FIX.md`, `CHANGES_SUMMARY.md`, and `OUI_LOOKUP_DEBUGGING.md` with step-by-step guides, troubleshooting, verification commands, and explanations of the OUI lookup process and dataset requirements. These docs help developers and users verify the presence, format, and build configuration of the OUI database. [[1]](diffhunk://#diff-78d3c8fe02280b23d1c89ab0028626a7065a2707d617c86a27525c140ff5a39eR1-R244) [[2]](diffhunk://#diff-154752f844a11e0cdaa4ecdb16a62e64f1741d4210c6bf03bbbb61cf6574e0b6R1-R215) [[3]](diffhunk://#diff-c4e0fecdd41c84145207d0b99b1483ee33c6f8736899d3c693b1ef233b9b766fR1-R157) * Added `OUI_DATASET.md` to explain why the repo ships an empty `oui.csv`, how to generate/import a compliant OUI dataset, and how to ensure it's included in the app. **Feature and Model Enhancements:** * Updated the network scan result model and settings to include optional `MacAddress` and `Vendor` fields, and a `LookupMacVendor` setting to control vendor lookup. This prepares the app to display enriched scan results. [[1]](diffhunk://#diff-21fda80b92ec05f7573ad70939944d39696f6ef0a70c795b83419938096d1016R51-R52) [[2]](diffhunk://#diff-21fda80b92ec05f7573ad70939944d39696f6ef0a70c795b83419938096d1016R65-R75) **Codebase Utilities:** * Introduced `NeighborCacheHelper` to retrieve MAC addresses for local IPv4 devices by querying the Windows ARP/neighbor cache, supporting accurate MAC-to-vendor mapping. * Added a utility method `ClearAllPingMessages()` to `SQLiteHelper` for clearing ping message records, supporting easier database management during testing or troubleshooting. These changes collectively improve the reliability, transparency, and supportability of MAC vendor lookups in the application, making it easier to diagnose and permanently resolve related issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>