[PR #86] [MERGED] Move Rdata encoding/decoding to new classes #94

New issue

Closed

opened 2026-03-04 23:24:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/86
Author: @samuelwilliams
Created: 2/1/2019
Status: ✅ Merged
Merged: 2/1/2019
Merged by: @samuelwilliams

Base: master ← Head: feature/rdata-encoding

📝 Commits (3)

42d02f8 Separate Rdata encoder and decoder into their own classes.
3665b61 .
7b5aa07 Merge branch 'master' of https://github.com/yswery/PHP-DNS-SERVER into feature/rdata-encoding

📊 Changes

6 files changed (+307 additions, -142 deletions)

View changed files

📝 src/Decoder.php (+1 -57)
📝 src/Encoder.php (+14 -69)
➕ src/RdataDecoder.php (+138 -0)
➕ src/RdataEncoder.php (+131 -0)
📝 src/Tests/DecoderTest.php (+10 -8)
📝 src/Tests/EncoderTest.php (+13 -8)

📄 Description

The methods for encoding and decoding rdata has been placed into new classes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/86 **Author:** [@samuelwilliams](https://github.com/samuelwilliams) **Created:** 2/1/2019 **Status:** ✅ Merged **Merged:** 2/1/2019 **Merged by:** [@samuelwilliams](https://github.com/samuelwilliams) **Base:** `master` ← **Head:** `feature/rdata-encoding` --- ### 📝 Commits (3) - [`42d02f8`](https://github.com/yswery/PHP-DNS-SERVER/commit/42d02f817a415460759db6167666efb51a3f2f02) Separate Rdata encoder and decoder into their own classes. - [`3665b61`](https://github.com/yswery/PHP-DNS-SERVER/commit/3665b6157116b1ea7464c50b6c2b42b76f598577) . - [`7b5aa07`](https://github.com/yswery/PHP-DNS-SERVER/commit/7b5aa07f0ca477621a59d9fd9fed8e099e7b8f1a) Merge branch 'master' of https://github.com/yswery/PHP-DNS-SERVER into feature/rdata-encoding ### 📊 Changes **6 files changed** (+307 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `src/Decoder.php` (+1 -57) 📝 `src/Encoder.php` (+14 -69) ➕ `src/RdataDecoder.php` (+138 -0) ➕ `src/RdataEncoder.php` (+131 -0) 📝 `src/Tests/DecoderTest.php` (+10 -8) 📝 `src/Tests/EncoderTest.php` (+13 -8) </details> ### 📄 Description The methods for encoding and decoding rdata has been placed into new classes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>