starred/PHP-DNS-SERVER
1
0
Fork 0
mirror of https://github.com/yswery/PHP-DNS-SERVER.git synced 2026-04-26 09:45:54 +03:00
Code Issues 6 Projects Releases 4 Packages Wiki Activity

[GH-ISSUE #23] Server not testable #8

New issue
Closed
opened 2026-03-04 23:23:41 +03:00 by kerem · 2 comments
kerem commented 2026-03-04 23:23:41 +03:00
Owner
Copy link

Originally created by @samuelwilliams on GitHub (Apr 17, 2017).
Original GitHub issue: https://github.com/yswery/PHP-DNS-SERVER/issues/23

The Server object is not very testable in its current form. I would suggest separating the encoders and decoders into their own respective classes. Unit tests could then be developed to test and further develop the encoder and decoder methods. This would also serve to make the Server object singularly responsible for handling the socket stream, therefore it would be less complex.

Originally created by @samuelwilliams on GitHub (Apr 17, 2017). Original GitHub issue: https://github.com/yswery/PHP-DNS-SERVER/issues/23 The `Server` object is not very testable in its current form. I would suggest separating the encoders and decoders into their own respective classes. Unit tests could then be developed to test and further develop the encoder and decoder methods. This would also serve to make the `Server` object singularly responsible for handling the socket stream, therefore it would be less complex.
kerem closed this issue 2026-03-04 23:23:41 +03:00
kerem commented 2026-03-04 23:23:42 +03:00
Author
Owner
Copy link

@samuelwilliams commented on GitHub (Sep 4, 2018):

There is a new branch for the server unit tests. With the addition of the tests, bugs and errors are coming to light for which I have either fixed in this branch or raised issues.

<!-- gh-comment-id:418477957 --> @samuelwilliams commented on GitHub (Sep 4, 2018): There is a new branch for the server unit tests. With the addition of the tests, bugs and errors are coming to light for which I have either fixed in this branch or raised issues.
kerem commented 2026-03-04 23:23:42 +03:00
Author
Owner
Copy link

@samuelwilliams commented on GitHub (Sep 7, 2018):

#55

<!-- gh-comment-id:419592753 --> @samuelwilliams commented on GitHub (Sep 7, 2018): #55
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
v1.4.1
v1.4
v1.3
v1.2
v1.1.3
v1.1.2
V1.1.1
v1.1
v1.0.1
v1.0
v0.3
v0.2
v0.1
Labels
Clear labels   
bug

   
enhancement

   
enhancement

   
hacktoberfest

   
pull-request

Mirrored from GitHub Pull Request

  
question
No labels
bug
enhancement
enhancement
hacktoberfest
pull-request
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PHP-DNS-SERVER#8
No description provided.